You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/26 03:40:53 UTC

[GitHub] [flink] lsyldliu commented on a diff in pull request #19424: [FLINK-22732][table] Restrict ALTER TABLE from setting empty table op…

lsyldliu commented on code in PR #19424:
URL: https://github.com/apache/flink/pull/19424#discussion_r858233964


##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/SqlToOperationConverter.java:
##########
@@ -547,6 +547,12 @@ private Operation convertAlterTableOptions(
             ObjectIdentifier tableIdentifier,
             CatalogTable oldTable,
             SqlAlterTableOptions alterTableOptions) {
+        Map<String, String> setOptions =

Review Comment:
   I think we can follow the `ALTER TABLE ... RESET ...` which check empty also in here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org