You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "jt2594838 (via GitHub)" <gi...@apache.org> on 2024/09/02 02:44:14 UTC
[PR] Fix WAL Exception catch & support new DataTypes in QueryDataSetUtils [iotdb]
jt2594838 opened a new pull request, #13375:
URL: https://github.com/apache/iotdb/pull/13375
https://github.com/apache/iotdb/pull/13359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [To: rc/1.3.3]Fix WAL Exception catch & support new DataTypes in QueryDataSetUtils [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #13375:
URL: https://github.com/apache/iotdb/pull/13375#issuecomment-2323764732
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=13375) **Quality Gate passed**
Issues
 [9 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=13375&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=13375&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=13375&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=13375&metric=new_coverage&view=list)
 [0.6% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=13375&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=13375)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [To: rc/1.3.3]Fix WAL Exception catch & support new DataTypes in QueryDataSetUtils [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #13375:
URL: https://github.com/apache/iotdb/pull/13375#issuecomment-2323728498
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=13375) **Quality Gate passed**
Issues
 [9 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=13375&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=13375&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=13375&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=13375&metric=new_coverage&view=list)
 [0.6% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=13375&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=13375)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [To: rc/1.3.3]Fix WAL Exception catch & support new DataTypes in QueryDataSetUtils [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #13375:
URL: https://github.com/apache/iotdb/pull/13375#issuecomment-2323799816
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/13375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `5.71429%` with `33 lines` in your changes missing coverage. Please review.
> Project coverage is 41.45%. Comparing base [(`9a0e9d4`)](https://app.codecov.io/gh/apache/iotdb/commit/9a0e9d4d8c6836a009065e33a64f0e21b7e8d23f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`0288fb6`)](https://app.codecov.io/gh/apache/iotdb/commit/0288fb6f2aa8ed7ad0f6da794da65c2626d9b200?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
| [Files with missing lines](https://app.codecov.io/gh/apache/iotdb/pull/13375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ag/column/unary/scalar/RoundColumnTransformer.java](https://app.codecov.io/gh/apache/iotdb/pull/13375?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Ftransformation%2Fdag%2Fcolumn%2Funary%2Fscalar%2FRoundColumnTransformer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvdHJhbnNmb3JtYXRpb24vZGFnL2NvbHVtbi91bmFyeS9zY2FsYXIvUm91bmRDb2x1bW5UcmFuc2Zvcm1lci5qYXZh) | 0.00% | [28 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../db/storageengine/dataregion/wal/io/WALReader.java](https://app.codecov.io/gh/apache/iotdb/pull/13375?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fstorageengine%2Fdataregion%2Fwal%2Fio%2FWALReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvc3RvcmFnZWVuZ2luZS9kYXRhcmVnaW9uL3dhbC9pby9XQUxSZWFkZXIuamF2YQ==) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## rc/1.3.3 #13375 +/- ##
==============================================
- Coverage 41.45% 41.45% -0.01%
Complexity 71 71
==============================================
Files 3439 3440 +1
Lines 219121 219153 +32
Branches 26056 26059 +3
==============================================
- Hits 90842 90839 -3
- Misses 128279 128314 +35
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/13375?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [To: rc/1.3.3]Fix WAL Exception catch & support new DataTypes in QueryDataSetUtils [iotdb]
Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 merged PR #13375:
URL: https://github.com/apache/iotdb/pull/13375
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org