[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6966: [MINOR] Remove update state api from PartitionEvaluator

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #6966:
URL: https://github.com/apache/arrow-datafusion/pull/6966#discussion_r1264065264


##########
datafusion/physical-expr/src/window/built_in.rs:
##########
@@ -157,18 +162,20 @@ impl WindowExpr for BuiltInWindowExpr {
             };
             let state = &mut window_state.state;
 
-            let (values, order_bys) =
-                self.get_values_orderbys(&partition_batch_state.record_batch)?;
+            let batch_ref = &partition_batch_state.record_batch;
+            let mut values = self.evaluate_args(batch_ref)?;
+            let order_bys = if evaluator.uses_window_frame() | evaluator.include_rank() {

Review Comment:
   I wonder if this should be the `||` boolean operator rather than `|` bitwise (though perhaps it doesn't matter as they  are probably the same for booleans)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org