You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/02/12 21:56:35 UTC
[GitHub] [incubator-mxnet] sl1pkn07 opened a new issue #17579: typo in
CmakeLists.txt about OPENMP_FOUND
sl1pkn07 opened a new issue #17579: typo in CmakeLists.txt about OPENMP_FOUND
URL: https://github.com/apache/incubator-mxnet/issues/17579
https://github.com/apache/incubator-mxnet/blob/f0d1d9dd8879920c68290b6f520f97a17444354c/CMakeLists.txt#L420
according cmake documentation, `OPENMP_FOUND` should be `OpenMP_FOUND`
https://cmake.org/cmake/help/git-master/module/FindOpenMP.html
greetings
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu commented on issue #17579: typo in
CmakeLists.txt about OPENMP_FOUND
Posted by GitBox <gi...@apache.org>.
leezu commented on issue #17579: typo in CmakeLists.txt about OPENMP_FOUND
URL: https://github.com/apache/incubator-mxnet/issues/17579#issuecomment-585496098
Ok. I'm not sure why this worked so far then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] szha commented on issue #17579: typo in
CmakeLists.txt about OPENMP_FOUND
Posted by GitBox <gi...@apache.org>.
szha commented on issue #17579: typo in CmakeLists.txt about OPENMP_FOUND
URL: https://github.com/apache/incubator-mxnet/issues/17579#issuecomment-585439899
Thanks for bringing this up. Would you be open to contributing a patch to fix it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] sl1pkn07 commented on issue #17579: typo in
CmakeLists.txt about OPENMP_FOUND
Posted by GitBox <gi...@apache.org>.
sl1pkn07 commented on issue #17579: typo in CmakeLists.txt about OPENMP_FOUND
URL: https://github.com/apache/incubator-mxnet/issues/17579#issuecomment-585458059
@szha done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu commented on issue #17579: typo in
CmakeLists.txt about OPENMP_FOUND
Posted by GitBox <gi...@apache.org>.
leezu commented on issue #17579: typo in CmakeLists.txt about OPENMP_FOUND
URL: https://github.com/apache/incubator-mxnet/issues/17579#issuecomment-585467367
Variables are case sensitive in CMake syntax. This is only an optical issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu edited a comment on issue #17579: typo in
CmakeLists.txt about OPENMP_FOUND
Posted by GitBox <gi...@apache.org>.
leezu edited a comment on issue #17579: typo in CmakeLists.txt about OPENMP_FOUND
URL: https://github.com/apache/incubator-mxnet/issues/17579#issuecomment-585467367
Variables are case insensitive in CMake syntax. This is only an optical issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu commented on issue #17579: typo in
CmakeLists.txt about OPENMP_FOUND
Posted by GitBox <gi...@apache.org>.
leezu commented on issue #17579: typo in CmakeLists.txt about OPENMP_FOUND
URL: https://github.com/apache/incubator-mxnet/issues/17579#issuecomment-585500555
`OPENMP_FOUND` is also supported variable.
https://gitlab.kitware.com/cmake/cmake/blob/master/Modules/FindOpenMP.cmake#L584
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] sl1pkn07 edited a comment on issue #17579: typo
in CmakeLists.txt about OPENMP_FOUND
Posted by GitBox <gi...@apache.org>.
sl1pkn07 edited a comment on issue #17579: typo in CmakeLists.txt about OPENMP_FOUND
URL: https://github.com/apache/incubator-mxnet/issues/17579#issuecomment-585470957
not at all, a example
https://github.com/Nadrin/Quartz/issues/2 (the first part)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] sl1pkn07 commented on issue #17579: typo in
CmakeLists.txt about OPENMP_FOUND
Posted by GitBox <gi...@apache.org>.
sl1pkn07 commented on issue #17579: typo in CmakeLists.txt about OPENMP_FOUND
URL: https://github.com/apache/incubator-mxnet/issues/17579#issuecomment-585470957
not at all, a example
https://github.com/Nadrin/Quartz/issues/2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] szha closed issue #17579: typo in CmakeLists.txt about OPENMP_FOUND
Posted by GitBox <gi...@apache.org>.
szha closed issue #17579:
URL: https://github.com/apache/incubator-mxnet/issues/17579
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org