You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Jukka Zitting (JIRA)" <ji...@apache.org> on 2009/12/01 11:31:20 UTC
[jira] Created: (FELIX-1910) Normal URLs instead of Javascript
links in Licenses screen
Normal URLs instead of Javascript links in Licenses screen
----------------------------------------------------------
Key: FELIX-1910
URL: https://issues.apache.org/jira/browse/FELIX-1910
Project: Felix
Issue Type: Improvement
Components: Web Console
Affects Versions: webconsole-1.2.10
Reporter: Jukka Zitting
The Licenses screen in the Web Management Console uses links like javascript:displayBundle("123"); and javascript:displayFile("123", "Bundle Resources", "1"); which make it impossible to directly link to specific license information.
It would be better if all the exposed information had a normal http URL like in the Bundles screen. In fact, how about if license information was included in the bundle information page at http://.../bundles/123?
PS. Note that I'm looking at version 1.2.10 of the console, but since I didn't find relevant issues against more recent releases I believe this issue is still valid for the latest trunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1910) Normal URLs instead of Javascript
links in Licenses screen
Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835712#action_12835712 ]
Valentin Valchev commented on FELIX-1910:
-----------------------------------------
Typically the path to the license is /META-INF/LICENSE.kxml2
so uri becomes
/licenses/<bid>/META-INF/LICENSE.kxml2/path/to/my/inner.jar
it really becomes more harder to parse, thus more prune to errors.
Or should escape manually the strings in both JS & Servlet. But why bother to do manual escaping, if the servlet container does it for you, if parameters are used.
> Normal URLs instead of Javascript links in Licenses screen
> ----------------------------------------------------------
>
> Key: FELIX-1910
> URL: https://issues.apache.org/jira/browse/FELIX-1910
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: webconsole-1.2.10
> Reporter: Jukka Zitting
> Assignee: Felix Meschberger
>
> The Licenses screen in the Web Management Console uses links like javascript:displayBundle("123"); and javascript:displayFile("123", "Bundle Resources", "1"); which make it impossible to directly link to specific license information.
> It would be better if all the exposed information had a normal http URL like in the Bundles screen. In fact, how about if license information was included in the bundle information page at http://.../bundles/123?
> PS. Note that I'm looking at version 1.2.10 of the console, but since I didn't find relevant issues against more recent releases I believe this issue is still valid for the latest trunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (FELIX-1910) Normal URLs instead of
Javascript links in Licenses screen
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835677#action_12835677 ]
Felix Meschberger edited comment on FELIX-1910 at 2/19/10 10:16 AM:
--------------------------------------------------------------------
Patch 16.license_plugin.patch [1] of FELIX-1988 includes a first step into this direction, but there is a problem IMHO: The patch uses three request parameters to select the license file to return:
bid -- bundle ID
url -- the license file to return
jar -- (optional) the path to an embedded library providing the license file
IMHO, this should all be encoded in the request URL, something like
http://..../licenses/<bundleId>/<path_to_jar>.jar/<path_to_file>
where the "<path_to_jar>.jar" part would be optional (and the .jar suffix could be used as a match-marker
In addition, instead of sending back INTERNAL_SERVER_ERROR and FORBIDDEN, I would just send back 404/NOT FOUND if the path is invalid or the file cannot be resolved or an illegal file is requested.
[1] https://issues.apache.org/jira/secure/attachment/12436299/16.license_plugin.patch
was (Author: fmeschbe):
Patch 16.license_plugin.patch [1] of FELIX-1988 includes a first step into this direction, but there is a problem IMHO: The patch uses three request parameters to select the license file to return:
bid -- bundle ID
url -- the license file to return
jar -- (optional) the path to an embedded library providing the license file
IMHO, this should all be encoded in the request URL, something like
http://..../licenses/<bundleId>/<path_to_jar>.jar/<path_to_file>
where the "<path_to_jar>.jar" part would be optional (and the .jar suffix could be used as a match-marker
In addition, instead of sending back INTERNAL_SERVER_ERROR and FORBIDDEN, I would just send back 404/NOT FOUND if the path is invalid or the file cannot be resolved or an illegal file is requested.
> Normal URLs instead of Javascript links in Licenses screen
> ----------------------------------------------------------
>
> Key: FELIX-1910
> URL: https://issues.apache.org/jira/browse/FELIX-1910
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: webconsole-1.2.10
> Reporter: Jukka Zitting
> Assignee: Felix Meschberger
>
> The Licenses screen in the Web Management Console uses links like javascript:displayBundle("123"); and javascript:displayFile("123", "Bundle Resources", "1"); which make it impossible to directly link to specific license information.
> It would be better if all the exposed information had a normal http URL like in the Bundles screen. In fact, how about if license information was included in the bundle information page at http://.../bundles/123?
> PS. Note that I'm looking at version 1.2.10 of the console, but since I didn't find relevant issues against more recent releases I believe this issue is still valid for the latest trunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1910) Normal URLs instead of Javascript
links in Licenses screen
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835677#action_12835677 ]
Felix Meschberger commented on FELIX-1910:
------------------------------------------
Patch 16.license_plugin.patch [1] of FELIX-1988 includes a first step into this direction, but there is a problem IMHO: The patch uses three request parameters to select the license file to return:
bid -- bundle ID
url -- the license file to return
jar -- (optional) the path to an embedded library providing the license file
IMHO, this should all be encoded in the request URL, something like
http://..../licenses/<bundleId>/<path_to_jar>.jar/<path_to_file>
where the "<path_to_jar>.jar" part would be optional (and the .jar suffix could be used as a match-marker
In addition, instead of sending back INTERNAL_SERVER_ERROR and FORBIDDEN, I would just send back 404/NOT FOUND if the path is invalid or the file cannot be resolved or an illegal file is requested.
> Normal URLs instead of Javascript links in Licenses screen
> ----------------------------------------------------------
>
> Key: FELIX-1910
> URL: https://issues.apache.org/jira/browse/FELIX-1910
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: webconsole-1.2.10
> Reporter: Jukka Zitting
> Assignee: Felix Meschberger
>
> The Licenses screen in the Web Management Console uses links like javascript:displayBundle("123"); and javascript:displayFile("123", "Bundle Resources", "1"); which make it impossible to directly link to specific license information.
> It would be better if all the exposed information had a normal http URL like in the Bundles screen. In fact, how about if license information was included in the bundle information page at http://.../bundles/123?
> PS. Note that I'm looking at version 1.2.10 of the console, but since I didn't find relevant issues against more recent releases I believe this issue is still valid for the latest trunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1910) Normal URLs instead of Javascript
links in Licenses screen
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835781#action_12835781 ]
Felix Meschberger commented on FELIX-1910:
------------------------------------------
Actually, I propose the other way around:
/licenses/<bid>/path/to/my/inner.jar/META-INF/LICENSE.kxml2
Here you can identify easily identify the parts:
1. the licenses name
2. the bundle id
3. up to a ".jar/" string: the inner library path
4. remains the file path
3. is optional, thus if, there is no ".jar/" substring, the file is not in an embedded library.
> Normal URLs instead of Javascript links in Licenses screen
> ----------------------------------------------------------
>
> Key: FELIX-1910
> URL: https://issues.apache.org/jira/browse/FELIX-1910
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: webconsole-1.2.10
> Reporter: Jukka Zitting
> Assignee: Felix Meschberger
>
> The Licenses screen in the Web Management Console uses links like javascript:displayBundle("123"); and javascript:displayFile("123", "Bundle Resources", "1"); which make it impossible to directly link to specific license information.
> It would be better if all the exposed information had a normal http URL like in the Bundles screen. In fact, how about if license information was included in the bundle information page at http://.../bundles/123?
> PS. Note that I'm looking at version 1.2.10 of the console, but since I didn't find relevant issues against more recent releases I believe this issue is still valid for the latest trunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (FELIX-1910) Normal URLs instead of Javascript links
in Licenses screen
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler closed FELIX-1910.
-----------------------------------
> Normal URLs instead of Javascript links in Licenses screen
> ----------------------------------------------------------
>
> Key: FELIX-1910
> URL: https://issues.apache.org/jira/browse/FELIX-1910
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: webconsole-1.2.10
> Reporter: Jukka Zitting
> Assignee: Felix Meschberger
> Fix For: webconsole-3.0.0
>
>
> The Licenses screen in the Web Management Console uses links like javascript:displayBundle("123"); and javascript:displayFile("123", "Bundle Resources", "1"); which make it impossible to directly link to specific license information.
> It would be better if all the exposed information had a normal http URL like in the Bundles screen. In fact, how about if license information was included in the bundle information page at http://.../bundles/123?
> PS. Note that I'm looking at version 1.2.10 of the console, but since I didn't find relevant issues against more recent releases I believe this issue is still valid for the latest trunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (FELIX-1910) Normal URLs instead of Javascript
links in Licenses screen
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger resolved FELIX-1910.
--------------------------------------
Resolution: Fixed
Fix Version/s: webconsole-3.0.0
In Rev. 912361 implemented the proposed URL-based scheme with one difference: using the JAR-URL separator "!/".
Examples:
.../licenses/5/META-INF/LICENSE -- META-INF/LICENSE file of Bundle 5
.../licenses/6/library.jar!/README -- README file of library.jar embedded in Bundle 6
Plus added testcases for URL parser
> Normal URLs instead of Javascript links in Licenses screen
> ----------------------------------------------------------
>
> Key: FELIX-1910
> URL: https://issues.apache.org/jira/browse/FELIX-1910
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: webconsole-1.2.10
> Reporter: Jukka Zitting
> Assignee: Felix Meschberger
> Fix For: webconsole-3.0.0
>
>
> The Licenses screen in the Web Management Console uses links like javascript:displayBundle("123"); and javascript:displayFile("123", "Bundle Resources", "1"); which make it impossible to directly link to specific license information.
> It would be better if all the exposed information had a normal http URL like in the Bundles screen. In fact, how about if license information was included in the bundle information page at http://.../bundles/123?
> PS. Note that I'm looking at version 1.2.10 of the console, but since I didn't find relevant issues against more recent releases I believe this issue is still valid for the latest trunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1910) Normal URLs instead of Javascript
links in Licenses screen
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784166#action_12784166 ]
Felix Meschberger commented on FELIX-1910:
------------------------------------------
Currently the license display page loads the license files from all the bundles when the page is rendered. Thus the javascript URLs actually do dynamic HTML manipulation.
As an extension to this (very useful) request, we might also want to delay-load this license information.
As for license information in the bundle display list: I would assume you mean we include a link to the license files to be displayed on demand, right ?
> Normal URLs instead of Javascript links in Licenses screen
> ----------------------------------------------------------
>
> Key: FELIX-1910
> URL: https://issues.apache.org/jira/browse/FELIX-1910
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: webconsole-1.2.10
> Reporter: Jukka Zitting
>
> The Licenses screen in the Web Management Console uses links like javascript:displayBundle("123"); and javascript:displayFile("123", "Bundle Resources", "1"); which make it impossible to directly link to specific license information.
> It would be better if all the exposed information had a normal http URL like in the Bundles screen. In fact, how about if license information was included in the bundle information page at http://.../bundles/123?
> PS. Note that I'm looking at version 1.2.10 of the console, but since I didn't find relevant issues against more recent releases I believe this issue is still valid for the latest trunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (FELIX-1910) Normal URLs instead of Javascript
links in Licenses screen
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger reassigned FELIX-1910:
----------------------------------------
Assignee: Felix Meschberger
> Normal URLs instead of Javascript links in Licenses screen
> ----------------------------------------------------------
>
> Key: FELIX-1910
> URL: https://issues.apache.org/jira/browse/FELIX-1910
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: webconsole-1.2.10
> Reporter: Jukka Zitting
> Assignee: Felix Meschberger
>
> The Licenses screen in the Web Management Console uses links like javascript:displayBundle("123"); and javascript:displayFile("123", "Bundle Resources", "1"); which make it impossible to directly link to specific license information.
> It would be better if all the exposed information had a normal http URL like in the Bundles screen. In fact, how about if license information was included in the bundle information page at http://.../bundles/123?
> PS. Note that I'm looking at version 1.2.10 of the console, but since I didn't find relevant issues against more recent releases I believe this issue is still valid for the latest trunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1910) Normal URLs instead of Javascript
links in Licenses screen
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784171#action_12784171 ]
Jukka Zitting commented on FELIX-1910:
--------------------------------------
> As for license information in the bundle display list: I would assume you mean
> we include a link to the license files to be displayed on demand, right?
Yes, that would probably be the cleanest approach. The license information files can at times be pretty heavy, so including them inline in the bundle information page can be troublesome.
> Normal URLs instead of Javascript links in Licenses screen
> ----------------------------------------------------------
>
> Key: FELIX-1910
> URL: https://issues.apache.org/jira/browse/FELIX-1910
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: webconsole-1.2.10
> Reporter: Jukka Zitting
>
> The Licenses screen in the Web Management Console uses links like javascript:displayBundle("123"); and javascript:displayFile("123", "Bundle Resources", "1"); which make it impossible to directly link to specific license information.
> It would be better if all the exposed information had a normal http URL like in the Bundles screen. In fact, how about if license information was included in the bundle information page at http://.../bundles/123?
> PS. Note that I'm looking at version 1.2.10 of the console, but since I didn't find relevant issues against more recent releases I believe this issue is still valid for the latest trunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.