You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/06/09 09:45:45 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6392: sched/mqueue: remove sched_lock to improve performance

xiaoxiang781216 commented on code in PR #6392:
URL: https://github.com/apache/incubator-nuttx/pull/6392#discussion_r893245427


##########
sched/mqueue/mq_notify.c:
##########
@@ -114,13 +114,9 @@ int mq_notify(mqd_t mqdes, FAR const struct sigevent *notification)
       /* No.. return EBADF */
 
       errval = EBADF;
-      goto errout_without_lock;
+      goto errout;
     }
 
-  /* Get a pointer to the message queue */
-
-  sched_lock();

Review Comment:
   should we add critical section here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org