[GitHub] [hadoop] mukund-thakur commented on a diff in pull request #5780: HADOOP-18781. ABFS Output stream thread pools getting shutdown during GC.

["mukund-thakur (via GitHub)" <gi...@apache.org>]

mukund-thakur commented on code in PR #5780:
URL: https://github.com/apache/hadoop/pull/5780#discussion_r1244433151


##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsOutputStream.java:
##########
@@ -84,4 +88,34 @@ public void testMaxRequestsAndQueueCapacity() throws Exception {
     }
   }
 
+  /**
+   * Verify the passing of AzureBlobFileSystem reference to AbfsOutputStream
+   * to make sure that the FS instance is not eligible for GC.
+   *
+   */
+  @Test
+  public void testAzureBlobFileSystemBackReferenceInOutputStream()
+      throws Exception {

Review Comment:
   Yes, System.gc() doesn't always trigger gc but you can call it 5 times in a loop which will increase the chance of triggering gc. 
   So I guess better to add the test. The test won't fail even if gc is not called. But if gc gets triggered once in a while we will have some coverage and we can always run the test manually. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org