You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ch...@apache.org on 2016/10/09 20:36:42 UTC

[1/3] [math] MATH-1387: making sudo required, upping memory profile

Repository: commons-math
Updated Branches:
  refs/heads/master d9e43edd1 -> f672e826f


MATH-1387: making sudo required, upping memory profile


Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-math/commit/47f30578
Tree: http://git-wip-us.apache.org/repos/asf/commons-math/tree/47f30578
Diff: http://git-wip-us.apache.org/repos/asf/commons-math/diff/47f30578

Branch: refs/heads/master
Commit: 47f305786ebdc4376b1c18e109013e7181087e05
Parents: d9e43ed
Author: Rob Tompkins <ch...@gmail.com>
Authored: Sun Oct 9 16:00:37 2016 -0400
Committer: Rob Tompkins <ch...@gmail.com>
Committed: Sun Oct 9 16:00:37 2016 -0400

----------------------------------------------------------------------
 .travis.yml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-math/blob/47f30578/.travis.yml
----------------------------------------------------------------------
diff --git a/.travis.yml b/.travis.yml
index fbfdd15..af39663 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,10 +1,13 @@
 language: java
-sudo: false
+sudo: required
 
 jdk:
   - openjdk7
   - oraclejdk8
 
+env:
+  - MAVEN_OPTS="-Xmx6g -Xms2g"
+
 # only build master and the MATH_3_X branch
 branches:
   only:

Re: [3/3] [math] MATH-1387: adding RetryRunner to RandomUtilsDataGeneratorJDKSecureRandomTest

Posted by Gilles <gi...@harfang.homelinux.org>.
On Mon, 10 Oct 2016 01:51:37 +0200, Emmanuel Bourg wrote:
> Le 10/10/2016 � 01:40, Gilles a �crit :
>
>> For months, Travis consistently did not work (i.e. even when
>> that non-deterministic passed, which it does 99% of the time
>> for truly uniform RNG) even though local and Jenkins builds
>> went fine.
>>
>> The problem reported as MATH-1387 was about what was wrong with
>> the Travis configuration. [Thanks to Rob for fixing it.]
>
> The bug isn't titled "The Travis configuration is broken", it's 
> titled
> "Travis does not work",

My point, exactly: it has been discussed (ML) that something
was broken with Travis (be it configuration, as it turned out
or something in its environment) since the build was OK otherwise.

> this means the resolution may include
> configuration fixes *and* test stabilization.

What you call "test stabilization" did strictly _nothing_
to make Travis work.

> Rob even pasted the log of
> the test failure in the bug so the intent of this commit is clear.

The commits were fine (separate issues in separate commits).
Only the message was not correct as far as the "RetryRunner"
change is concerned.
Not a big deal, but confusing.

Enough talk about this as far as I'm concerned.

Gilles

>
> Emmanuel Bourg
>



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [3/3] [math] MATH-1387: adding RetryRunner to RandomUtilsDataGeneratorJDKSecureRandomTest

Posted by Gilles <gi...@harfang.homelinux.org>.
On Sun, 9 Oct 2016 20:07:21 -0400, Rob Tompkins wrote:
> I'm indifferent on the documentation here. But, I figure the changes
> should be in there either way.

Sure.

> If we think it better to have two jiras
> to sufficiently document the change, I'll back it out, make just the
> .travis.yml change and open a separate jira for the RetryRunner.

No need to worry more about it.
The nit-picking about my little remark is enough of a trace.

Regards,
Gilles

> Just let me know what you guys think is best, and I'll head that 
> direction.
>
> Cheers,
> -Rob
>
>
>> On Oct 9, 2016, at 7:51 PM, Emmanuel Bourg <eb...@apache.org> 
>> wrote:
>>
>>> Le 10/10/2016 � 01:40, Gilles a �crit :
>>>
>>> For months, Travis consistently did not work (i.e. even when
>>> that non-deterministic passed, which it does 99% of the time
>>> for truly uniform RNG) even though local and Jenkins builds
>>> went fine.
>>>
>>> The problem reported as MATH-1387 was about what was wrong with
>>> the Travis configuration. [Thanks to Rob for fixing it.]
>>
>> The bug isn't titled "The Travis configuration is broken", it's 
>> titled
>> "Travis does not work", this means the resolution may include
>> configuration fixes *and* test stabilization. Rob even pasted the 
>> log of
>> the test failure in the bug so the intent of this commit is clear.
>>
>> Emmanuel Bourg
>>
>>
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [3/3] [math] MATH-1387: adding RetryRunner to RandomUtilsDataGeneratorJDKSecureRandomTest

Posted by Rob Tompkins <ch...@gmail.com>.
I'm indifferent on the documentation here. But, I figure the changes should be in there either way. If we think it better to have two jiras to sufficiently document the change, I'll back it out, make just the .travis.yml change and open a separate jira for the RetryRunner. 

Just let me know what you guys think is best, and I'll head that direction. 

Cheers,
-Rob


> On Oct 9, 2016, at 7:51 PM, Emmanuel Bourg <eb...@apache.org> wrote:
> 
>> Le 10/10/2016 à 01:40, Gilles a écrit :
>> 
>> For months, Travis consistently did not work (i.e. even when
>> that non-deterministic passed, which it does 99% of the time
>> for truly uniform RNG) even though local and Jenkins builds
>> went fine.
>> 
>> The problem reported as MATH-1387 was about what was wrong with
>> the Travis configuration. [Thanks to Rob for fixing it.]
> 
> The bug isn't titled "The Travis configuration is broken", it's titled
> "Travis does not work", this means the resolution may include
> configuration fixes *and* test stabilization. Rob even pasted the log of
> the test failure in the bug so the intent of this commit is clear.
> 
> Emmanuel Bourg
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

Re: [3/3] [math] MATH-1387: adding RetryRunner to RandomUtilsDataGeneratorJDKSecureRandomTest

Posted by Emmanuel Bourg <eb...@apache.org>.
Le 10/10/2016 � 01:40, Gilles a �crit :

> For months, Travis consistently did not work (i.e. even when
> that non-deterministic passed, which it does 99% of the time
> for truly uniform RNG) even though local and Jenkins builds
> went fine.
> 
> The problem reported as MATH-1387 was about what was wrong with
> the Travis configuration. [Thanks to Rob for fixing it.]

The bug isn't titled "The Travis configuration is broken", it's titled
"Travis does not work", this means the resolution may include
configuration fixes *and* test stabilization. Rob even pasted the log of
the test failure in the bug so the intent of this commit is clear.

Emmanuel Bourg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [3/3] [math] MATH-1387: adding RetryRunner to RandomUtilsDataGeneratorJDKSecureRandomTest

Posted by Gilles <gi...@harfang.homelinux.org>.
On Mon, 10 Oct 2016 01:26:15 +0200, Emmanuel Bourg wrote:
> Le 10/10/2016 � 01:21, Gilles a �crit :
>
>> The first sentence of that comment was:
>>  "The latter is not related to either Travis or the JVM version."
>>
>> Whereas MATH-1387 is entitled:
>>   "Travis CI does not work in master branch"
>
> For Travis to work the tests have to pass. That's why the build has 
> to
> be stable, and the non deterministic tests retried.

For months, Travis consistently did not work (i.e. even when
that non-deterministic passed, which it does 99% of the time
for truly uniform RNG) even though local and Jenkins builds
went fine.

The problem reported as MATH-1387 was about what was wrong with
the Travis configuration. [Thanks to Rob for fixing it.]

See:
   
https://github.com/apache/commons-math/pull/44/commits/47f305786ebdc4376b1c18e109013e7181087e05

Only that change should have been tagged with "MATH-1387".


Gilles

>
> Emmanuel Bourg
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [3/3] [math] MATH-1387: adding RetryRunner to RandomUtilsDataGeneratorJDKSecureRandomTest

Posted by Emmanuel Bourg <eb...@apache.org>.
Le 10/10/2016 � 01:21, Gilles a �crit :

> The first sentence of that comment was:
>  "The latter is not related to either Travis or the JVM version."
> 
> Whereas MATH-1387 is entitled:
>   "Travis CI does not work in master branch"

For Travis to work the tests have to pass. That's why the build has to
be stable, and the non deterministic tests retried.

Emmanuel Bourg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [3/3] [math] MATH-1387: adding RetryRunner to RandomUtilsDataGeneratorJDKSecureRandomTest

Posted by Gilles <gi...@harfang.homelinux.org>.
On Mon, 10 Oct 2016 01:12:05 +0200, Emmanuel Bourg wrote:
> Le 10/10/2016 � 00:59, Gilles a �crit :
>
>> How is this change related to MATH-1387 ?
>
> In MATH-1387 you suggested: "Sometimes the sequence is not uniform
> enough according to the statistics criterion. Just run the build 
> again",
> that's what this commit clearly does: it runs the failed test again.

The first sentence of that comment was:
  "The latter is not related to either Travis or the JVM version."

Whereas MATH-1387 is entitled:
   "Travis CI does not work in master branch"

Gilles

> Emmanuel Bourg
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [3/3] [math] MATH-1387: adding RetryRunner to RandomUtilsDataGeneratorJDKSecureRandomTest

Posted by Emmanuel Bourg <eb...@apache.org>.
Le 10/10/2016 � 00:59, Gilles a �crit :

> How is this change related to MATH-1387 ?

In MATH-1387 you suggested: "Sometimes the sequence is not uniform
enough according to the statistics criterion. Just run the build again",
that's what this commit clearly does: it runs the failed test again.

Emmanuel Bourg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [3/3] [math] MATH-1387: adding RetryRunner to RandomUtilsDataGeneratorJDKSecureRandomTest

Posted by Gilles <gi...@harfang.homelinux.org>.
On Sun, 09 Oct 2016 20:36:44 -0000, chtompki@apache.org wrote:
> MATH-1387: adding RetryRunner to 
> RandomUtilsDataGeneratorJDKSecureRandomTest

How is this change related to MATH-1387 ?

Gilles

>
>
> Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo
> Commit: 
> http://git-wip-us.apache.org/repos/asf/commons-math/commit/f672e826
> Tree: 
> http://git-wip-us.apache.org/repos/asf/commons-math/tree/f672e826
> Diff: 
> http://git-wip-us.apache.org/repos/asf/commons-math/diff/f672e826
>
> Branch: refs/heads/master
> Commit: f672e826f51824582273fa1f5b6ec37aa5fdb2fd
> Parents: b9cd355
> Author: Rob Tompkins <ch...@gmail.com>
> Authored: Sun Oct 9 16:23:08 2016 -0400
> Committer: Rob Tompkins <ch...@gmail.com>
> Committed: Sun Oct 9 16:23:08 2016 -0400
>
> 
> ----------------------------------------------------------------------
>  .../random/RandomUtilsDataGeneratorJDKSecureRandomTest.java      | 4 
> ++++
>  1 file changed, 4 insertions(+)
> 
> ----------------------------------------------------------------------
>
>
> 
> http://git-wip-us.apache.org/repos/asf/commons-math/blob/f672e826/src/test/java/org/apache/commons/math4/random/RandomUtilsDataGeneratorJDKSecureRandomTest.java
> 
> ----------------------------------------------------------------------
> diff --git
> 
> a/src/test/java/org/apache/commons/math4/random/RandomUtilsDataGeneratorJDKSecureRandomTest.java
> 
> b/src/test/java/org/apache/commons/math4/random/RandomUtilsDataGeneratorJDKSecureRandomTest.java
> index cd4696b..beba117 100644
> ---
> 
> a/src/test/java/org/apache/commons/math4/random/RandomUtilsDataGeneratorJDKSecureRandomTest.java
> +++
> 
> b/src/test/java/org/apache/commons/math4/random/RandomUtilsDataGeneratorJDKSecureRandomTest.java
> @@ -16,12 +16,16 @@
>   */
>  package org.apache.commons.math4.random;
>
> +import org.apache.commons.math4.RetryRunner;
> +import org.junit.runner.RunWith;
> +
>  import java.security.SecureRandom;
>
>  /**
>   * Test cases for the {@link RandomUtils#DataGenerator} class, using
>   * {@link SecureRandom} as the underlying source of randomness.
>   */
> +@RunWith(RetryRunner.class)
>  public class RandomUtilsDataGeneratorJDKSecureRandomTest
>      extends RandomUtilsDataGeneratorAbstractTest {


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

[3/3] [math] MATH-1387: adding RetryRunner to RandomUtilsDataGeneratorJDKSecureRandomTest

Posted by ch...@apache.org.
MATH-1387: adding RetryRunner to RandomUtilsDataGeneratorJDKSecureRandomTest


Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-math/commit/f672e826
Tree: http://git-wip-us.apache.org/repos/asf/commons-math/tree/f672e826
Diff: http://git-wip-us.apache.org/repos/asf/commons-math/diff/f672e826

Branch: refs/heads/master
Commit: f672e826f51824582273fa1f5b6ec37aa5fdb2fd
Parents: b9cd355
Author: Rob Tompkins <ch...@gmail.com>
Authored: Sun Oct 9 16:23:08 2016 -0400
Committer: Rob Tompkins <ch...@gmail.com>
Committed: Sun Oct 9 16:23:08 2016 -0400

----------------------------------------------------------------------
 .../random/RandomUtilsDataGeneratorJDKSecureRandomTest.java      | 4 ++++
 1 file changed, 4 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-math/blob/f672e826/src/test/java/org/apache/commons/math4/random/RandomUtilsDataGeneratorJDKSecureRandomTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/math4/random/RandomUtilsDataGeneratorJDKSecureRandomTest.java b/src/test/java/org/apache/commons/math4/random/RandomUtilsDataGeneratorJDKSecureRandomTest.java
index cd4696b..beba117 100644
--- a/src/test/java/org/apache/commons/math4/random/RandomUtilsDataGeneratorJDKSecureRandomTest.java
+++ b/src/test/java/org/apache/commons/math4/random/RandomUtilsDataGeneratorJDKSecureRandomTest.java
@@ -16,12 +16,16 @@
  */
 package org.apache.commons.math4.random;
 
+import org.apache.commons.math4.RetryRunner;
+import org.junit.runner.RunWith;
+
 import java.security.SecureRandom;
 
 /**
  * Test cases for the {@link RandomUtils#DataGenerator} class, using
  * {@link SecureRandom} as the underlying source of randomness.
  */
+@RunWith(RetryRunner.class)
 public class RandomUtilsDataGeneratorJDKSecureRandomTest
     extends RandomUtilsDataGeneratorAbstractTest {

[2/3] [math] MATH-1387: adding RetryRunner to RandomUtilsDataGeneratorAbstractTest

Posted by ch...@apache.org.
MATH-1387: adding RetryRunner to RandomUtilsDataGeneratorAbstractTest


Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-math/commit/b9cd3558
Tree: http://git-wip-us.apache.org/repos/asf/commons-math/tree/b9cd3558
Diff: http://git-wip-us.apache.org/repos/asf/commons-math/diff/b9cd3558

Branch: refs/heads/master
Commit: b9cd3558133ae9f26aec73e0bda3a8f635d137f7
Parents: 47f3057
Author: Rob Tompkins <ch...@gmail.com>
Authored: Sun Oct 9 16:09:55 2016 -0400
Committer: Rob Tompkins <ch...@gmail.com>
Committed: Sun Oct 9 16:09:55 2016 -0400

----------------------------------------------------------------------
 .../math4/random/RandomUtilsDataGeneratorAbstractTest.java        | 3 +++
 1 file changed, 3 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-math/blob/b9cd3558/src/test/java/org/apache/commons/math4/random/RandomUtilsDataGeneratorAbstractTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/math4/random/RandomUtilsDataGeneratorAbstractTest.java b/src/test/java/org/apache/commons/math4/random/RandomUtilsDataGeneratorAbstractTest.java
index f24a266..59170d4 100644
--- a/src/test/java/org/apache/commons/math4/random/RandomUtilsDataGeneratorAbstractTest.java
+++ b/src/test/java/org/apache/commons/math4/random/RandomUtilsDataGeneratorAbstractTest.java
@@ -23,6 +23,7 @@ import java.util.List;
 import java.util.Random;
 import java.util.List;
 
+import org.apache.commons.math4.RetryRunner;
 import org.apache.commons.math4.TestUtils;
 import org.apache.commons.math4.exception.MathIllegalArgumentException;
 import org.apache.commons.math4.stat.Frequency;
@@ -31,10 +32,12 @@ import org.apache.commons.math4.util.FastMath;
 import org.apache.commons.rng.UniformRandomProvider;
 import org.junit.Assert;
 import org.junit.Test;
+import org.junit.runner.RunWith;
 
 /**
  * Test cases for the {@link RandomUtils#DataGenerator} class.
  */
+@RunWith(RetryRunner.class)
 public abstract class RandomUtilsDataGeneratorAbstractTest {
     private final long smallSampleSize = 1000;
     private final double[] expected = { 250, 250, 250, 250 };