You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2022/01/03 20:31:13 UTC

[GitHub] [calcite] gunnarmorling commented on a change in pull request #2672: CALCITE-0000 Removing dependency to commons-lang3

gunnarmorling commented on a change in pull request #2672:
URL: https://github.com/apache/calcite/pull/2672#discussion_r777689952



##########
File path: file/src/main/java/org/apache/calcite/adapter/file/CsvEnumerator.java
##########
@@ -68,18 +69,16 @@
   private final RowConverter<E> rowConverter;
   private @Nullable E current;
 
-  private static final FastDateFormat TIME_FORMAT_DATE;
-  private static final FastDateFormat TIME_FORMAT_TIME;
-  private static final FastDateFormat TIME_FORMAT_TIMESTAMP;
+  private static final DateTimeFormatter TIME_FORMAT_DATE;
+  private static final DateTimeFormatter TIME_FORMAT_TIME;
+  private static final DateTimeFormatter TIME_FORMAT_TIMESTAMP;

Review comment:
       So `DateTimeFormatter` was added in Java 8. Can we use this? I.e. what's the minimum Java baseline for Calcite?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org