You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "breautek (via GitHub)" <gi...@apache.org> on 2023/04/14 12:45:09 UTC

[GitHub] [cordova-android] breautek opened a new pull request, #1597: deprecate: CoreAndroid.getBuildConfigValue

breautek opened a new pull request, #1597:
URL: https://github.com/apache/cordova-android/pull/1597

   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   
   We have 2 copies of an implementation of `getBuildConfigValue`, one inside `CoreAndroid` and another in `BuildConfig`.
   The `BuildConfig` variant was directly migrated from our old deprecated `cordova-plugin-compat` package, so it is more likely that the `BuildConfig` variant is used more than the `CoreAndroid` version.
   
   ### Description
   <!-- Describe your changes in detail -->
   
   Added `@Deprecated` decorator for build compilation warning.
   
   ![Screenshot from 2023-04-14 09-30-16](https://user-images.githubusercontent.com/11200662/232045484-b43b7d56-b1e2-4b86-a790-f797e0e6fe41.png)
   
   
   Add `@deprecated` JavaDoc for code editor hints and information on how to migrate.
   
   ![Screenshot from 2023-04-14 09-31-06](https://user-images.githubusercontent.com/11200662/232045584-3475aeae-65d1-4a2f-b02e-db0d1ab8eece.png)
   
   ![Screenshot from 2023-04-14 09-30-50](https://user-images.githubusercontent.com/11200662/232045523-d15264a6-d3a8-42e0-9df1-65a2a9046dee.png)
   
   Changed `CoreAndroid.getBuildConfigValue` to simply call and return the result of `BuildHelper.getBuildConfigValue`
   
   Note that the screenshots are from a test app that was changed to use the deprecated API in the `MainActivity`. `MainActivity` template doesn't actually use the deprecated API.
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   `npm test` and manual testing.
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-android] codecov-commenter commented on pull request #1597: deprecate: CoreAndroid.getBuildConfigValue

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1597:
URL: https://github.com/apache/cordova-android/pull/1597#issuecomment-1508459430

   ## [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1597?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1597](https://codecov.io/gh/apache/cordova-android/pull/1597?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6a39057) into [master](https://codecov.io/gh/apache/cordova-android/commit/2252c09a49f0e0ff6de40a7ceb988e61c330ffc7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2252c09) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1597   +/-   ##
   =======================================
     Coverage   71.82%   71.82%           
   =======================================
     Files          23       23           
     Lines        1796     1796           
   =======================================
     Hits         1290     1290           
     Misses        506      506           
   ```
   
   
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-android] breautek merged pull request #1597: deprecate: CoreAndroid.getBuildConfigValue

Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek merged PR #1597:
URL: https://github.com/apache/cordova-android/pull/1597


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org