You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2022/07/28 00:09:36 UTC

[GitHub] [openwhisk-wskdebug] kokoc opened a new issue, #114: Cleanup annotations

kokoc opened a new issue, #114:
URL: https://github.com/apache/openwhisk-wskdebug/issues/114

   Wskdebug sets `wskdebug` annotation and uses it to detect current deployment status of agent - https://github.com/apache/openwhisk-wskdebug/blob/master/src/agentmgr.js#L530
   
   This annotation is not deleted during the cleanup phase and wskdebug will prevent all consequent runs thinking it's already running.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [openwhisk-wskdebug] alexkli commented on issue #114: Cleanup annotations

Posted by GitBox <gi...@apache.org>.
alexkli commented on issue #114:
URL: https://github.com/apache/openwhisk-wskdebug/issues/114#issuecomment-1201211483

   Can you consistently reproduce it?
   
   It is supposed to be reset when the [original action is restored](https://github.com/apache/openwhisk-wskdebug/blob/master/src/agentmgr.js#L449-L453). This could be a change in behavior of openwhisk on how it handles annotations on `update`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [openwhisk-wskdebug] kokoc commented on issue #114: Cleanup annotations

Posted by GitBox <gi...@apache.org>.
kokoc commented on issue #114:
URL: https://github.com/apache/openwhisk-wskdebug/issues/114#issuecomment-1203030069

   @alexkli yes, I can reproduce it. My steps:
   * Launch Adobe app builder project using `aio app run`
   * Launch a debug session with `--cleanup` flag
   * Stop the debug session
   ❌  All consequent runs of debug session are blocked


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [openwhisk-wskdebug] alexkli commented on issue #114: Cleanup annotations

Posted by GitBox <gi...@apache.org>.
alexkli commented on issue #114:
URL: https://github.com/apache/openwhisk-wskdebug/issues/114#issuecomment-1203965641

   cc @shazron @selfxp in case you folks have cycles.
   
   It seems we need to find a way to actually delete the "wskdebug=true" annotation [here](https://github.com/apache/openwhisk-wskdebug/blob/master/src/agentmgr.js#L449-L453).
   
   Some ideas to explore:
   
   1. is there a trick to make update() overwrite the annotations?
   2. delete all annotations before writing them again (without the wskdebug field)?
   3. set wskdebug=false? (least preferable - I want the action to look exactly like before, with no `wskdebug` stuff left behind)
   4. other ideas?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org