You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/12/11 06:55:26 UTC
Review Request 64495: Fixed a typo in resource provider config API
and added validation tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64495/
-----------------------------------------------------------
Review request for mesos, James DeFelice and Jie Yu.
Repository: mesos
Description
-------
Fixed a typo in resource provider config API and added validation tests.
Diffs
-----
include/mesos/agent/agent.proto d464afe313ef9fe619892e0f1e15058a3612fda0
include/mesos/v1/agent/agent.proto 91fe5e1e1b421498dcfe6787f7698c60b0275603
src/tests/slave_validation_tests.cpp e81b65bb67954e14eb82d8b80ffa679c2f9515fb
Diff: https://reviews.apache.org/r/64495/diff/1/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 64495: Fixed a typo in resource provider config
API and added validation tests.
Posted by James DeFelice <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64495/#review193389
-----------------------------------------------------------
Ship it!
Ship It!
- James DeFelice
On Dec. 11, 2017, 6:55 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64495/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2017, 6:55 a.m.)
>
>
> Review request for mesos, James DeFelice and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a typo in resource provider config API and added validation tests.
>
>
> Diffs
> -----
>
> include/mesos/agent/agent.proto d464afe313ef9fe619892e0f1e15058a3612fda0
> include/mesos/v1/agent/agent.proto 91fe5e1e1b421498dcfe6787f7698c60b0275603
> src/tests/slave_validation_tests.cpp e81b65bb67954e14eb82d8b80ffa679c2f9515fb
>
>
> Diff: https://reviews.apache.org/r/64495/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 64495: Fixed a typo in resource provider config
API and added validation tests.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64495/#review193462
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Dec. 11, 2017, 6:55 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64495/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2017, 6:55 a.m.)
>
>
> Review request for mesos, James DeFelice and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a typo in resource provider config API and added validation tests.
>
>
> Diffs
> -----
>
> include/mesos/agent/agent.proto d464afe313ef9fe619892e0f1e15058a3612fda0
> include/mesos/v1/agent/agent.proto 91fe5e1e1b421498dcfe6787f7698c60b0275603
> src/tests/slave_validation_tests.cpp e81b65bb67954e14eb82d8b80ffa679c2f9515fb
>
>
> Diff: https://reviews.apache.org/r/64495/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 64495: Fixed a typo in resource provider config
API and added validation tests.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64495/#review193428
-----------------------------------------------------------
FAIL: Some Mesos tests failed.
Reviews applied: `['64439', '64469', '64479', '64495']`
Failed command: `D:\DCOS\mesos\src\mesos-tests.exe --verbose`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64495
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64495/logs/mesos-tests-stdout.log):
```
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2389 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2414 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2480 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2504 ms total)
[----------] Global test environment tear-down
[==========] 829 tests from 84 test cases ran. (321967 ms total)
[ PASSED ] 819 tests.
[ FAILED ] 10 tests, listed below:
[ FAILED ] OfferOperationStatusUpdateManagerTest.UpdateAndAckNonTerminalUpdate
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverCheckpointedStream
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverEmptyFile
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverTerminatedStream
[ FAILED ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdate
[ FAILED ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdateAfterRecover
[ FAILED ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAck
[ FAILED ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAckAfterRecover
[ FAILED ] OfferOperationStatusUpdateManagerTest.NonStrictRecoveryCorruptedFile
[ FAILED ] SlaveTest.ResourceProviderPublishAll
10 FAILED TESTS
YOU HAVE 201 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64495/logs/mesos-tests-stderr.log):
```
I1211 18:56:56.469055 9848 exec.cpp:237] Executor registered on agent 1cdde4fb-d155-4437-a635-0c25c43e2823-S0
I1211 18:56:56.473055 1020 executor.cpp:171] Received SUBSCRIBED event
I1211 18:56:56.477085 1020 executor.cpp:175] Subscribed executor on build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I1211 18:56:56.477085 1020 executor.cpp:171] Received LAUNCH event
I1211 18:56:56.482079 1020 executor.cpp:637] Starting task 57ba1290-355d-4518-aaed-f37cb4371d30
I1211 18:56:56.570085 1020 executor.cpp:477] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I1211 18:56:57.122074 1020 executor.cpp:650] Forked command at 9312
I1211 18:56:57.150075 6980 exec.cpp:435] Executor asked to shutdown
I1211 18:56:57.151222 1020 executor.cpp:171] Received SHUTDOWN event
I1211 18:56:57.151222 1020 executor.cpp:747] Shutting down
I1211 18:56:57.151222 1020 executor.cpp:854] Sending SIGTERM to process tree at pid 95-4437-a635-0c25c43e2823-0000
I1211 18:56:57.148072 5512 master.cpp:10103] Updating the state of task 57ba1290-355d-4518-aaed-f37cb4371d30 of framework 1cdde4fb-d155-4437-a635-0c25c43e2823-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I1211 18:56:57.148072 3644 slave.cpp:3400] Shutting down framework 1cdde4fb-d155-4437-a635-0c25c43e2823-0000
I1211 18:56:57.149075 3644 slave.cpp:6091] Shutting down executor '57ba1290-355d-4518-aaed-f37cb4371d30' of framework 1cdde4fb-d155-4437-a635-0c25c43e2823-0000 at executor(1)@10.3.1.11:54065
I1211 18:56:57.150075 8392 slave.cpp:909] Agent terminating
W1211 18:56:57.150075 8392 slave.cpp:3396] Ignoring shutdown framework 1cdde4fb-d155-4437-a635-0c25c43e2823-0000 because it is terminating
I1211 18:56:57.151222 5512 master.cpp:10209] Removing task 57ba1290-355d-4518-aaed-f37cb4371d30 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 1cdde4fb-d155-4437-a635-0c25c43e2823-0000 on agent 1cdde4fb-d155-4437-a635-0c25c43e2823-S0 at slave(326)@10.3.1.11:54044 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1211 18:56:57.153070 5640 containerizer.cpp:2328] Destroying container 35ae486a-0fa4-4446-8fcc-2f3b7326f77d in RUNNING state
I1211 18:56:57.153070 5640 containerizer.cpp:2930] Transitioning the state of container 35ae486a-0fa4-4446-8fcc-2f3b7326f77d from RUNNING to DESTROYING
I1211 18:56:57.154075 5640 launcher.cpp:156] Asked to destroy container 35ae486a-0fa4-4446-8fcc-2f3b7326f77d
I1211 18:56:57.154075 5512 master.cpp:1310] Agent 1cdde4fb-d155-4437-a635-0c25c43e2823-S0 at slave(326)@10.3.1.11:54044 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1211 18:56:57.154075 5512 master.cpp:3369] Disconnecting agent 1cdde4fb-d155-4437-a635-0c25c43e2823-S0 at slave(326)@10.3.1.11:54044 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1211 18:56:57.155097 5512 master.cpp:3388] Deactivating agent 1cdde4fb-d155-4437-a635-0c25c43e2823-S0 at slave(326)@10.3.1.11:54044 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1211 18:56:57.155097 5088 hierarchical.cpp:344] Removed framework 1cdde4fb-d155-4437-a635-0c25c43e2823-0000
I1211 18:56:57.155097 8152 hierarchical.cpp:762] Agent 1cdde4fb-d155-4437-a635-0c25c43e2823-S0 deactivated
I1211 18:56:57.219429 3644 containerizer.cpp:2779] Container 35ae486a-0fa4-4446-8fcc-2f3b7326f77d has exited
I1211 18:56:57.248112 8392 master.cpp:1152] Master terminating
I1211 18:56:57.250083 2000 hierarchical.cpp:605] Removed agent 1cdde4fb-d155-4437-a635-0c25c43e2823-S0
I1211 18:56:57.560106 796 process.cpp:887] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Dec. 11, 2017, 6:55 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64495/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2017, 6:55 a.m.)
>
>
> Review request for mesos, James DeFelice and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a typo in resource provider config API and added validation tests.
>
>
> Diffs
> -----
>
> include/mesos/agent/agent.proto d464afe313ef9fe619892e0f1e15058a3612fda0
> include/mesos/v1/agent/agent.proto 91fe5e1e1b421498dcfe6787f7698c60b0275603
> src/tests/slave_validation_tests.cpp e81b65bb67954e14eb82d8b80ffa679c2f9515fb
>
>
> Diff: https://reviews.apache.org/r/64495/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>