[jira] [Commented] (SLING-2718) Add integration test for the error handling mechanism

["Bertrand Delacretaz (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13566379#comment-13566379 ] 

Bertrand Delacretaz commented on SLING-2718:
--------------------------------------------

Looks good to me, two comments:

1) Maybe you could add some dynamic stuff to 404.jsp to verify that it gets the correct scripting context - not sure if it's needed at this stage

2) I'd remove the 404.jsp at the end of the test, for test isolation
                
> Add integration test for the error handling mechanism 
> ------------------------------------------------------
>
>                 Key: SLING-2718
>                 URL: https://issues.apache.org/jira/browse/SLING-2718
>             Project: Sling
>          Issue Type: Improvement
>          Components: Launchpad
>            Reporter: Antonio Sanso
>            Assignee: Antonio Sanso
>            Priority: Minor
>         Attachments: SLING-2718-patch.txt
>
>
> It would be nice to have some integration tests for the  error handling mechanism  described in http://sling.apache.org/site/errorhandling.html.
> I am attaching a patch that will contain the skeleton of such tests.
> Once committed I will extend it further.
> WDYT?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira