You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/26 06:10:41 UTC
[GitHub] [pulsar] horizonzy opened a new pull request, #17291: [Branch-2.10] [fix] [broker] Fix bookeeper packages npe
horizonzy opened a new pull request, #17291:
URL: https://github.com/apache/pulsar/pull/17291
<img width="974" alt="image" src="https://user-images.githubusercontent.com/22524871/186832471-267965f2-67da-40e5-affd-69f1a294fb0a.png">
The `zookeeperServers` already deprecated, we recommend `metadataStoreUrl`.
In `BookKeeperPackagesStorage`, it still use `zookeeperServers`, didn't compatible with `metadataStoreUrl`, so it will throw NPE.
I notice that there are two PRs already fix it, but it only in Branch-2.11, so move it to Branch-2.10.
#14384, #14595
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [ ] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] horizonzy commented on pull request #17291: [Branch-2.10] [fix] [broker] Fix bookeeper packages npe
Posted by GitBox <gi...@apache.org>.
horizonzy commented on PR #17291:
URL: https://github.com/apache/pulsar/pull/17291#issuecomment-1229374105
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #17291: [Branch-2.10] [fix] [broker] Fix bookeeper packages npe
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #17291:
URL: https://github.com/apache/pulsar/pull/17291#issuecomment-1229374246
@horizonzy Please provide a correct documentation label for your PR.
Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] horizonzy commented on pull request #17291: [Branch-2.10] [fix] [broker] Fix bookeeper packages npe
Posted by GitBox <gi...@apache.org>.
horizonzy commented on PR #17291:
URL: https://github.com/apache/pulsar/pull/17291#issuecomment-1244926055
Fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #17291: [Branch-2.10] [fix] [broker] Fix bookeeper packages npe
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on PR #17291:
URL: https://github.com/apache/pulsar/pull/17291#issuecomment-1244923824
@horizonzy I cherry-picked this PR again. See https://github.com/apache/pulsar/commit/1df5734a3898d371a9d75d921ecb6d73b2847a71. It seems like the bug can be fixed by cherry-picking https://github.com/apache/pulsar/pull/16969.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- merged pull request #17291: [Branch-2.10] [fix] [broker] Fix bookeeper packages npe
Posted by GitBox <gi...@apache.org>.
Technoboy- merged PR #17291:
URL: https://github.com/apache/pulsar/pull/17291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #17291: [Branch-2.10] [fix] [broker] Fix bookeeper packages npe
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on PR #17291:
URL: https://github.com/apache/pulsar/pull/17291#issuecomment-1244838107
@horizonzy I reverted this PR in branch-2.10. It looks like this PR brings an incompatibility issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org