You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Yash Sharma <ya...@gmail.com> on 2015/08/01 08:16:59 UTC
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/
-----------------------------------------------------------
(Updated Aug. 1, 2015, 6:16 a.m.)
Review request for lens.
Changes
-------
New review comments for creating PathValidator with LensConf rather than util class.
@prongs: Need to check if its implemented as planned.
Bugs: LENS-634
https://issues.apache.org/jira/browse/LENS-634
Repository: lens
Description
-------
Added changes for file name suggestions on Tab. Changed String file paths to File.
https://issues.apache.org/jira/browse/LENS-634
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/LensConf.java 1f02431
lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java PRE-CREATION
lens-api/src/test/java/org/apache/lens/api/TestPathValidator.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java c059f30
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java ae04b3f
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java da11069
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d682
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
src/site/apt/user/cli.apt 5dd0bfb
Diff: https://reviews.apache.org/r/36178/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.982 s]
[INFO] Lens ............................................... SUCCESS [ 2.926 s]
[INFO] Lens API ........................................... SUCCESS [ 23.384 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 22.930 s]
[INFO] Lens Cube .......................................... SUCCESS [05:09 min]
[INFO] Lens DB storage .................................... SUCCESS [ 19.053 s]
[INFO] Lens Query Library ................................. SUCCESS [ 15.298 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:33 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.895 s]
[INFO] Lens Server ........................................ SUCCESS [05:02 min]
[INFO] Lens client ........................................ SUCCESS [ 36.456 s]
[INFO] Lens CLI ........................................... SUCCESS [02:07 min]
[INFO] Lens Examples ...................................... SUCCESS [ 9.820 s]
[INFO] Lens Distribution .................................. SUCCESS [ 7.816 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:15 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.677 s]
[INFO] Lens Regression .................................... SUCCESS [ 11.533 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:19 min
[INFO] Finished at: 2015-08-01T11:23:10+05:30
[INFO] Final Memory: 131M/421M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
> On Aug. 4, 2015, 6:53 a.m., Rajat Khandelwal wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java, line 188
> > <https://reviews.apache.org/r/36178/diff/10-11/?file=1024381#file1024381line188>
> >
> > Instead of creating a new one, let's use `new PathValidator(getClient().getConnection().getParams().getSessionConf())` inside `setClient` and store the variable.
> >
> > Now it sounds like path validator would be tied to `LensClient` instance, so it might be better to have the path validator inside lens client. And there, `connectToLensServer` is creating a `LensConnectionParams` instance which can be used for creating LensConf and instantiating PathValidator.
Implemented.
What about the BaseLensService changes ?
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review94006
-----------------------------------------------------------
On Aug. 4, 2015, 2:47 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 2:47 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-634
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/LensConf.java 1f02431
> lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java PRE-CREATION
> lens-api/src/test/java/org/apache/lens/api/TestPathValidator.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java c059f30
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 57c672c
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java da11069
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d682
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> src/site/apt/user/cli.apt 5dd0bfb
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.982 s]
> [INFO] Lens ............................................... SUCCESS [ 2.926 s]
> [INFO] Lens API ........................................... SUCCESS [ 23.384 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 22.930 s]
> [INFO] Lens Cube .......................................... SUCCESS [05:09 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.053 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 15.298 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:33 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.895 s]
> [INFO] Lens Server ........................................ SUCCESS [05:02 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.456 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:07 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.820 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 7.816 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:15 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.677 s]
> [INFO] Lens Regression .................................... SUCCESS [ 11.533 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:19 min
> [INFO] Finished at: 2015-08-01T11:23:10+05:30
> [INFO] Final Memory: 131M/421M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review94006
-----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java (line 188)
<https://reviews.apache.org/r/36178/#comment148508>
Instead of creating a new one, let's use `new PathValidator(getClient().getConnection().getParams().getSessionConf())` inside `setClient` and store the variable.
Now it sounds like path validator would be tied to `LensClient` instance, so it might be better to have the path validator inside lens client. And there, `connectToLensServer` is creating a `LensConnectionParams` instance which can be used for creating LensConf and instantiating PathValidator.
- Rajat Khandelwal
On Aug. 1, 2015, 11:46 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2015, 11:46 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-634
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/LensConf.java 1f02431
> lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java PRE-CREATION
> lens-api/src/test/java/org/apache/lens/api/TestPathValidator.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java c059f30
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java ae04b3f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java da11069
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d682
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> src/site/apt/user/cli.apt 5dd0bfb
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.982 s]
> [INFO] Lens ............................................... SUCCESS [ 2.926 s]
> [INFO] Lens API ........................................... SUCCESS [ 23.384 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 22.930 s]
> [INFO] Lens Cube .......................................... SUCCESS [05:09 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.053 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 15.298 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:33 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.895 s]
> [INFO] Lens Server ........................................ SUCCESS [05:02 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.456 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:07 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.820 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 7.816 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:15 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.677 s]
> [INFO] Lens Regression .................................... SUCCESS [ 11.533 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:19 min
> [INFO] Finished at: 2015-08-01T11:23:10+05:30
> [INFO] Final Memory: 131M/421M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review94068
-----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java (line 120)
<https://reviews.apache.org/r/36178/#comment148568>
Remove commented code.
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java (lines 184 - 185)
<https://reviews.apache.org/r/36178/#comment148569>
Can we safely assume it'll never be null? The non null check can be added in client's constructor at the end. use `Preconditions.checkArgument` for valid state creation.
lens-client/src/main/java/org/apache/lens/client/LensClient.java (line 237)
<https://reviews.apache.org/r/36178/#comment148571>
Since this is the only place `pathValidator` is being created, And going up the call heirarchy, all constructors come here, and `pathValidator` has no setters, it's 100% sure that at this point, pathValidator is null.
- Rajat Khandelwal
On Aug. 4, 2015, 8:18 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 8:18 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-634
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/LensConf.java 1f02431
> lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java PRE-CREATION
> lens-api/src/test/java/org/apache/lens/api/TestPathValidator.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java c059f30
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 57c672c
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java da11069
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d682
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> src/site/apt/user/cli.apt 5dd0bfb
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.077 s]
> [INFO] Lens ............................................... SUCCESS [ 3.106 s]
> [INFO] Lens API ........................................... SUCCESS [ 25.443 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 22.068 s]
> [INFO] Lens Cube .......................................... SUCCESS [05:09 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.055 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 14.572 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:31 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 37.434 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 16.330 s]
> [INFO] Lens Server ........................................ SUCCESS [05:05 min]
> [INFO] Lens client ........................................ SUCCESS [ 34.200 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:03 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.993 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 8.751 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:13 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.092 s]
> [INFO] Lens Regression .................................... SUCCESS [ 11.198 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:30 min
> [INFO] Finished at: 2015-08-04T20:07:56+05:30
> [INFO] Final Memory: 132M/375M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/
-----------------------------------------------------------
(Updated Aug. 6, 2015, 12:41 p.m.)
Review request for lens.
Changes
-------
New rebased patch.
Bugs: LENS-634
https://issues.apache.org/jira/browse/LENS-634
Repository: lens
Description
-------
Added changes for file name suggestions on Tab. Changed String file paths to File.
https://issues.apache.org/jira/browse/LENS-634
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/LensConf.java 1f02431
lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java PRE-CREATION
lens-api/src/test/java/org/apache/lens/api/TestPathValidator.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 51c4baf
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
lens-client/src/main/java/org/apache/lens/client/LensClient.java 57c672c
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 1487c5a
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 49fab8a
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 4143525
src/site/apt/user/cli.apt 5dd0bfb
Diff: https://reviews.apache.org/r/36178/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.972 s]
[INFO] Lens ............................................... SUCCESS [ 2.726 s]
[INFO] Lens API ........................................... SUCCESS [ 29.047 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 23.110 s]
[INFO] Lens Cube .......................................... SUCCESS [05:23 min]
[INFO] Lens DB storage .................................... SUCCESS [ 20.579 s]
[INFO] Lens Query Library ................................. SUCCESS [ 15.963 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:39 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.261 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 16.172 s]
[INFO] Lens Server ........................................ SUCCESS [05:44 min]
[INFO] Lens client ........................................ SUCCESS [ 44.869 s]
[INFO] Lens CLI ........................................... SUCCESS [02:10 min]
[INFO] Lens Examples ...................................... SUCCESS [ 9.891 s]
[INFO] Lens Distribution .................................. SUCCESS [ 8.484 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:35 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.117 s]
[INFO] Lens Regression .................................... SUCCESS [ 11.351 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:18 min
[INFO] Finished at: 2015-08-06T17:45:57+05:30
[INFO] Final Memory: 133M/405M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/
-----------------------------------------------------------
(Updated Aug. 5, 2015, 7:44 a.m.)
Review request for lens.
Changes
-------
Added build results.
Bugs: LENS-634
https://issues.apache.org/jira/browse/LENS-634
Repository: lens
Description
-------
Added changes for file name suggestions on Tab. Changed String file paths to File.
https://issues.apache.org/jira/browse/LENS-634
Diffs
-----
lens-api/src/main/java/org/apache/lens/api/LensConf.java 1f02431
lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java PRE-CREATION
lens-api/src/test/java/org/apache/lens/api/TestPathValidator.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java c059f30
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
lens-client/src/main/java/org/apache/lens/client/LensClient.java 57c672c
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java da11069
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d682
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
src/site/apt/user/cli.apt 5dd0bfb
Diff: https://reviews.apache.org/r/36178/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.313 s]
[INFO] Lens ............................................... SUCCESS [ 5.414 s]
[INFO] Lens API ........................................... SUCCESS [ 28.675 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 19.036 s]
[INFO] Lens Cube .......................................... SUCCESS [05:03 min]
[INFO] Lens DB storage .................................... SUCCESS [ 19.007 s]
[INFO] Lens Query Library ................................. SUCCESS [ 13.939 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:30 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 32.631 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 15.750 s]
[INFO] Lens Server ........................................ SUCCESS [05:36 min]
[INFO] Lens client ........................................ SUCCESS [ 38.828 s]
[INFO] Lens CLI ........................................... SUCCESS [02:08 min]
[INFO] Lens Examples ...................................... SUCCESS [ 9.725 s]
[INFO] Lens Distribution .................................. SUCCESS [ 9.639 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:37 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.107 s]
[INFO] Lens Regression .................................... SUCCESS [ 11.747 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20:27 min
[INFO] Finished at: 2015-08-05T12:55:25+05:30
[INFO] Final Memory: 132M/403M
[INFO] -----------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/
-----------------------------------------------------------
(Updated Aug. 4, 2015, 4:58 p.m.)
Review request for lens.
Bugs: LENS-634
https://issues.apache.org/jira/browse/LENS-634
Repository: lens
Description
-------
Added changes for file name suggestions on Tab. Changed String file paths to File.
https://issues.apache.org/jira/browse/LENS-634
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/LensConf.java 1f02431
lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java PRE-CREATION
lens-api/src/test/java/org/apache/lens/api/TestPathValidator.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java c059f30
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
lens-client/src/main/java/org/apache/lens/client/LensClient.java 57c672c
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java da11069
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d682
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
src/site/apt/user/cli.apt 5dd0bfb
Diff: https://reviews.apache.org/r/36178/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.077 s]
[INFO] Lens ............................................... SUCCESS [ 3.106 s]
[INFO] Lens API ........................................... SUCCESS [ 25.443 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 22.068 s]
[INFO] Lens Cube .......................................... SUCCESS [05:09 min]
[INFO] Lens DB storage .................................... SUCCESS [ 19.055 s]
[INFO] Lens Query Library ................................. SUCCESS [ 14.572 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:31 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 37.434 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 16.330 s]
[INFO] Lens Server ........................................ SUCCESS [05:05 min]
[INFO] Lens client ........................................ SUCCESS [ 34.200 s]
[INFO] Lens CLI ........................................... SUCCESS [02:03 min]
[INFO] Lens Examples ...................................... SUCCESS [ 9.993 s]
[INFO] Lens Distribution .................................. SUCCESS [ 8.751 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:13 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.092 s]
[INFO] Lens Regression .................................... SUCCESS [ 11.198 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:30 min
[INFO] Finished at: 2015-08-04T20:07:56+05:30
[INFO] Final Memory: 132M/375M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/
-----------------------------------------------------------
(Updated Aug. 4, 2015, 4:33 p.m.)
Review request for lens.
Changes
-------
New review comments.
Bugs: LENS-634
https://issues.apache.org/jira/browse/LENS-634
Repository: lens
Description
-------
Added changes for file name suggestions on Tab. Changed String file paths to File.
https://issues.apache.org/jira/browse/LENS-634
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/LensConf.java 1f02431
lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java PRE-CREATION
lens-api/src/test/java/org/apache/lens/api/TestPathValidator.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java c059f30
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
lens-client/src/main/java/org/apache/lens/client/LensClient.java 57c672c
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java da11069
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d682
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
src/site/apt/user/cli.apt 5dd0bfb
Diff: https://reviews.apache.org/r/36178/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.077 s]
[INFO] Lens ............................................... SUCCESS [ 3.106 s]
[INFO] Lens API ........................................... SUCCESS [ 25.443 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 22.068 s]
[INFO] Lens Cube .......................................... SUCCESS [05:09 min]
[INFO] Lens DB storage .................................... SUCCESS [ 19.055 s]
[INFO] Lens Query Library ................................. SUCCESS [ 14.572 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:31 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 37.434 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 16.330 s]
[INFO] Lens Server ........................................ SUCCESS [05:05 min]
[INFO] Lens client ........................................ SUCCESS [ 34.200 s]
[INFO] Lens CLI ........................................... SUCCESS [02:03 min]
[INFO] Lens Examples ...................................... SUCCESS [ 9.993 s]
[INFO] Lens Distribution .................................. SUCCESS [ 8.751 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:13 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.092 s]
[INFO] Lens Regression .................................... SUCCESS [ 11.198 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:30 min
[INFO] Finished at: 2015-08-04T20:07:56+05:30
[INFO] Final Memory: 132M/375M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/
-----------------------------------------------------------
(Updated Aug. 4, 2015, 2:48 p.m.)
Review request for lens.
Changes
-------
Added build results.
Bugs: LENS-634
https://issues.apache.org/jira/browse/LENS-634
Repository: lens
Description
-------
Added changes for file name suggestions on Tab. Changed String file paths to File.
https://issues.apache.org/jira/browse/LENS-634
Diffs
-----
lens-api/src/main/java/org/apache/lens/api/LensConf.java 1f02431
lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java PRE-CREATION
lens-api/src/test/java/org/apache/lens/api/TestPathValidator.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java c059f30
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
lens-client/src/main/java/org/apache/lens/client/LensClient.java 57c672c
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java da11069
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d682
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
src/site/apt/user/cli.apt 5dd0bfb
Diff: https://reviews.apache.org/r/36178/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.077 s]
[INFO] Lens ............................................... SUCCESS [ 3.106 s]
[INFO] Lens API ........................................... SUCCESS [ 25.443 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 22.068 s]
[INFO] Lens Cube .......................................... SUCCESS [05:09 min]
[INFO] Lens DB storage .................................... SUCCESS [ 19.055 s]
[INFO] Lens Query Library ................................. SUCCESS [ 14.572 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:31 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 37.434 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 16.330 s]
[INFO] Lens Server ........................................ SUCCESS [05:05 min]
[INFO] Lens client ........................................ SUCCESS [ 34.200 s]
[INFO] Lens CLI ........................................... SUCCESS [02:03 min]
[INFO] Lens Examples ...................................... SUCCESS [ 9.993 s]
[INFO] Lens Distribution .................................. SUCCESS [ 8.751 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:13 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.092 s]
[INFO] Lens Regression .................................... SUCCESS [ 11.198 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:30 min
[INFO] Finished at: 2015-08-04T20:07:56+05:30
[INFO] Final Memory: 132M/375M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/
-----------------------------------------------------------
(Updated Aug. 4, 2015, 2:47 p.m.)
Review request for lens.
Changes
-------
Implemented new review comments.
Bugs: LENS-634
https://issues.apache.org/jira/browse/LENS-634
Repository: lens
Description
-------
Added changes for file name suggestions on Tab. Changed String file paths to File.
https://issues.apache.org/jira/browse/LENS-634
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/LensConf.java 1f02431
lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java PRE-CREATION
lens-api/src/test/java/org/apache/lens/api/TestPathValidator.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java c059f30
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
lens-client/src/main/java/org/apache/lens/client/LensClient.java 57c672c
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java da11069
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d682
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
src/site/apt/user/cli.apt 5dd0bfb
Diff: https://reviews.apache.org/r/36178/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.982 s]
[INFO] Lens ............................................... SUCCESS [ 2.926 s]
[INFO] Lens API ........................................... SUCCESS [ 23.384 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 22.930 s]
[INFO] Lens Cube .......................................... SUCCESS [05:09 min]
[INFO] Lens DB storage .................................... SUCCESS [ 19.053 s]
[INFO] Lens Query Library ................................. SUCCESS [ 15.298 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:33 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.895 s]
[INFO] Lens Server ........................................ SUCCESS [05:02 min]
[INFO] Lens client ........................................ SUCCESS [ 36.456 s]
[INFO] Lens CLI ........................................... SUCCESS [02:07 min]
[INFO] Lens Examples ...................................... SUCCESS [ 9.820 s]
[INFO] Lens Distribution .................................. SUCCESS [ 7.816 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:15 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.677 s]
[INFO] Lens Regression .................................... SUCCESS [ 11.533 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:19 min
[INFO] Finished at: 2015-08-01T11:23:10+05:30
[INFO] Final Memory: 131M/421M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
> On Aug. 3, 2015, 8:16 a.m., Rajat Khandelwal wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java, line 189
> > <https://reviews.apache.org/r/36178/diff/10-11/?file=1024381#file1024381line189>
> >
> > path validator instance can be cached.
How are we planning to cache it ? Against the conf ?
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review93876
-----------------------------------------------------------
On Aug. 1, 2015, 6:16 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2015, 6:16 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-634
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/LensConf.java 1f02431
> lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java PRE-CREATION
> lens-api/src/test/java/org/apache/lens/api/TestPathValidator.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java c059f30
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java ae04b3f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java da11069
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d682
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> src/site/apt/user/cli.apt 5dd0bfb
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.982 s]
> [INFO] Lens ............................................... SUCCESS [ 2.926 s]
> [INFO] Lens API ........................................... SUCCESS [ 23.384 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 22.930 s]
> [INFO] Lens Cube .......................................... SUCCESS [05:09 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.053 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 15.298 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:33 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.895 s]
> [INFO] Lens Server ........................................ SUCCESS [05:02 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.456 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:07 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.820 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 7.816 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:15 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.677 s]
> [INFO] Lens Regression .................................... SUCCESS [ 11.533 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:19 min
> [INFO] Finished at: 2015-08-01T11:23:10+05:30
> [INFO] Final Memory: 131M/421M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
> On Aug. 3, 2015, 8:16 a.m., Rajat Khandelwal wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java, line 103
> > <https://reviews.apache.org/r/36178/diff/10-11/?file=1024383#file1024383line103>
> >
> > So for jar/file commands, we can't take `File` argument. Since `File` argument will give filename suggestions on client machine. And the path is supposed to be a valid path accessible from server machine.
Changed back to String paths.
> On Aug. 3, 2015, 8:16 a.m., Rajat Khandelwal wrote:
> > lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java, line 195
> > <https://reviews.apache.org/r/36178/diff/10-11/?file=1024379#file1024379line195>
> >
> > We can remove the `specialHandling` flag. It can be designed as a variable which defaults to `:///` and takes value from lens conf if present.
Implemented.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review93876
-----------------------------------------------------------
On Aug. 4, 2015, 2:47 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 2:47 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-634
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/LensConf.java 1f02431
> lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java PRE-CREATION
> lens-api/src/test/java/org/apache/lens/api/TestPathValidator.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java c059f30
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 57c672c
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java da11069
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d682
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> src/site/apt/user/cli.apt 5dd0bfb
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.982 s]
> [INFO] Lens ............................................... SUCCESS [ 2.926 s]
> [INFO] Lens API ........................................... SUCCESS [ 23.384 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 22.930 s]
> [INFO] Lens Cube .......................................... SUCCESS [05:09 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.053 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 15.298 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:33 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.895 s]
> [INFO] Lens Server ........................................ SUCCESS [05:02 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.456 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:07 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.820 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 7.816 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:15 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.677 s]
> [INFO] Lens Regression .................................... SUCCESS [ 11.533 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:19 min
> [INFO] Finished at: 2015-08-01T11:23:10+05:30
> [INFO] Final Memory: 131M/421M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review93876
-----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java (line 134)
<https://reviews.apache.org/r/36178/#comment148293>
We can remove the `specialHandling` flag. It can be designed as a variable which defaults to `:///` and takes value from lens conf if present.
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java (line 189)
<https://reviews.apache.org/r/36178/#comment148294>
path validator instance can be cached.
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java (line 200)
<https://reviews.apache.org/r/36178/#comment148295>
This can use the cached instance of path validator
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java (line 101)
<https://reviews.apache.org/r/36178/#comment148296>
So for jar/file commands, we can't take `File` argument. Since `File` argument will give filename suggestions on client machine. And the path is supposed to be a valid path accessible from server machine.
- Rajat Khandelwal
On Aug. 1, 2015, 11:46 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2015, 11:46 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-634
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/LensConf.java 1f02431
> lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java PRE-CREATION
> lens-api/src/test/java/org/apache/lens/api/TestPathValidator.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java c059f30
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java ae04b3f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java da11069
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d682
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> src/site/apt/user/cli.apt 5dd0bfb
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.982 s]
> [INFO] Lens ............................................... SUCCESS [ 2.926 s]
> [INFO] Lens API ........................................... SUCCESS [ 23.384 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 22.930 s]
> [INFO] Lens Cube .......................................... SUCCESS [05:09 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.053 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 15.298 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:33 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.895 s]
> [INFO] Lens Server ........................................ SUCCESS [05:02 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.456 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:07 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.820 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 7.816 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:15 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.677 s]
> [INFO] Lens Regression .................................... SUCCESS [ 11.533 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:19 min
> [INFO] Finished at: 2015-08-01T11:23:10+05:30
> [INFO] Final Memory: 131M/421M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>