You are viewing a plain text version of this content. The canonical link for it is here.

Posted to soap-user@ws.apache.org by Joseph Carew <jc...@kana.com> on 2002/02/05 20:52:58 UTC

MimePartSerializer bug?

This section of code in
org.apache.soap.encoding.soapenc.MimePartSerializer.java seems broken (lines
110-117):
 
DataSource ds = null;
DataHandler dh = null;
MimeBodyPart bp = null;
if (src instanceof InputStream)
        ds = new ByteArrayDataSource((InputStream)src,
                                          "application/octet-stream");
else if (src instanceof DataSource)
        ds = (DataSource)ds;
 
Shouldn't that last line be?
ds= (DataSource)src;
 
Casting a null seems like the wrong way to go.  Where does someone report
something like that if it really is a problem?