You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Pallavi Rao <pa...@inmobi.com> on 2016/01/05 06:28:02 UTC

Re: Review Request 41770: FALCON-1674 Fix the mapping of InstanceState status to workflow Status in InstancesResult

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41770/
-----------------------------------------------------------

(Updated Jan. 5, 2016, 5:28 a.m.)


Review request for Falcon.


Changes
-------

Addressed review comment.


Bugs: FALCON-1674
    https://issues.apache.org/jira/browse/FALCON-1674


Repository: falcon-git


Description
-------

Did the following:
1.Create a method to map InstanceState.STATE to InstancesResult.WorkflowStatus.
2. Add documentation to explain the different status.


Diffs (updated)
-----

  docs/src/site/twiki/restapi/InstanceList.twiki 229d6f9 
  oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java b486357 
  scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java bceab72 

Diff: https://reviews.apache.org/r/41770/diff/


Testing
-------

Manual testing done.


Thanks,

Pallavi Rao


Re: Review Request 41770: FALCON-1674 Fix the mapping of InstanceState status to workflow Status in InstancesResult

Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41770/#review112794
-----------------------------------------------------------

Ship it!


Ship It!

- Ajay Yadava


On Jan. 5, 2016, 5:28 a.m., Pallavi Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41770/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 5:28 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1674
>     https://issues.apache.org/jira/browse/FALCON-1674
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Did the following:
> 1.Create a method to map InstanceState.STATE to InstancesResult.WorkflowStatus.
> 2. Add documentation to explain the different status.
> 
> 
> Diffs
> -----
> 
>   docs/src/site/twiki/restapi/InstanceList.twiki 229d6f9 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java b486357 
>   scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java bceab72 
> 
> Diff: https://reviews.apache.org/r/41770/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> Pallavi Rao
> 
>