You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Dennis Byrne (JIRA)" <de...@myfaces.apache.org> on 2005/12/26 07:23:31 UTC
[jira] Created: (MYFACES-978) tree2 affected by changes to UIViewRoot
tree2 affected by changes to UIViewRoot
---------------------------------------
Key: MYFACES-978
URL: http://issues.apache.org/jira/browse/MYFACES-978
Project: MyFaces
Type: Bug
Components: Tomahawk
Versions: Nightly
Environment: nightly builds from dec. 22, 23 - tomcate 5.5
Reporter: Dennis Byrne
Priority: Minor
1.) Build and deploy the latest simple.war
2.) go the the tree2 (nice wrap) demo.
3.) click on the only rendered node.
4.) form submits, the action does fire, but tree2 is not rendered
The tree will render however if you explictly set the id of the tree's parent element, a panelgrid. The same behavior holds true if the parent element is h:form (tree renders w/ explicit form@id, does not render w/out form@id).
This behavior is not seen w/ builds of myFaces-all.jar before dec. 23. I also do not get this problem after checking out trunk, and doing a build after manually rolling back the latest change to UIViewRoot. This (harmless looking) change happened on the 23rd.
This does not happen using client side toggle.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-978) tree2 affected by changes to UIViewRoot
Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-978?page=comments#action_12361262 ]
Martin Marinschek commented on MYFACES-978:
-------------------------------------------
Well, upon reflection we may not save the state of the uniqueIdCounter even if this is less than optimal. I have reverted the patch. The thing is that the count needs to start anew on each request cause this count is not actually a unique counter for component instances, but for JSP-tag-instances... JSF1.2 will solve this in a better way.
regards,
Martin
> tree2 affected by changes to UIViewRoot
> ---------------------------------------
>
> Key: MYFACES-978
> URL: http://issues.apache.org/jira/browse/MYFACES-978
> Project: MyFaces
> Type: Bug
> Components: Tomahawk
> Versions: Nightly
> Environment: nightly builds from dec. 22, 23 - tomcate 5.5
> Reporter: Dennis Byrne
> Priority: Minor
>
> 1.) Build and deploy the latest simple.war
> 2.) go the the tree2 (nice wrap) demo.
> 3.) click on the only rendered node.
> 4.) form submits, the action does fire, but tree2 is not rendered
> The tree will render however if you explictly set the id of the tree's parent element, a panelgrid. The same behavior holds true if the parent element is h:form (tree renders w/ explicit form@id, does not render w/out form@id).
> This behavior is not seen w/ builds of myFaces-all.jar before dec. 23. I also do not get this problem after checking out trunk, and doing a build after manually rolling back the latest change to UIViewRoot. This (harmless looking) change happened on the 23rd.
> This does not happen using client side toggle.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-978) tree2 affected by changes to UIViewRoot
Posted by "zuma (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-978?page=comments#action_12361252 ]
zuma commented on MYFACES-978:
------------------------------
The IllegalStateException was thrown with implicit id on the datatable on the Dec 25 build. Explicit id helped avoiding the exception. Dec22 build was OK. Also on Dec25 build id's <i>for</i> which the "Required value is missing" message was supposed to be printed were not found.
> tree2 affected by changes to UIViewRoot
> ---------------------------------------
>
> Key: MYFACES-978
> URL: http://issues.apache.org/jira/browse/MYFACES-978
> Project: MyFaces
> Type: Bug
> Components: Tomahawk
> Versions: Nightly
> Environment: nightly builds from dec. 22, 23 - tomcate 5.5
> Reporter: Dennis Byrne
> Priority: Minor
>
> 1.) Build and deploy the latest simple.war
> 2.) go the the tree2 (nice wrap) demo.
> 3.) click on the only rendered node.
> 4.) form submits, the action does fire, but tree2 is not rendered
> The tree will render however if you explictly set the id of the tree's parent element, a panelgrid. The same behavior holds true if the parent element is h:form (tree renders w/ explicit form@id, does not render w/out form@id).
> This behavior is not seen w/ builds of myFaces-all.jar before dec. 23. I also do not get this problem after checking out trunk, and doing a build after manually rolling back the latest change to UIViewRoot. This (harmless looking) change happened on the 23rd.
> This does not happen using client side toggle.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-978) tree2 affected by changes to UIViewRoot
Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-978?page=comments#action_12361236 ]
Martin Marinschek commented on MYFACES-978:
-------------------------------------------
Hi Dennis,
I still think that my fix to UIViewRoot was valid and necessary. Maybe I forgot to do something which is necessary additionally?
Can the tree2 buffs say anything to this?
regards,
Martin
> tree2 affected by changes to UIViewRoot
> ---------------------------------------
>
> Key: MYFACES-978
> URL: http://issues.apache.org/jira/browse/MYFACES-978
> Project: MyFaces
> Type: Bug
> Components: Tomahawk
> Versions: Nightly
> Environment: nightly builds from dec. 22, 23 - tomcate 5.5
> Reporter: Dennis Byrne
> Priority: Minor
>
> 1.) Build and deploy the latest simple.war
> 2.) go the the tree2 (nice wrap) demo.
> 3.) click on the only rendered node.
> 4.) form submits, the action does fire, but tree2 is not rendered
> The tree will render however if you explictly set the id of the tree's parent element, a panelgrid. The same behavior holds true if the parent element is h:form (tree renders w/ explicit form@id, does not render w/out form@id).
> This behavior is not seen w/ builds of myFaces-all.jar before dec. 23. I also do not get this problem after checking out trunk, and doing a build after manually rolling back the latest change to UIViewRoot. This (harmless looking) change happened on the 23rd.
> This does not happen using client side toggle.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (MYFACES-978) tree2 affected by changes to UIViewRoot
Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-978?page=all ]
Martin Marinschek closed MYFACES-978:
-------------------------------------
Fix Version: Nightly
Resolution: Fixed
Assign To: Martin Marinschek
> tree2 affected by changes to UIViewRoot
> ---------------------------------------
>
> Key: MYFACES-978
> URL: http://issues.apache.org/jira/browse/MYFACES-978
> Project: MyFaces
> Type: Bug
> Components: Tomahawk
> Versions: Nightly
> Environment: nightly builds from dec. 22, 23 - tomcate 5.5
> Reporter: Dennis Byrne
> Assignee: Martin Marinschek
> Priority: Minor
> Fix For: Nightly
>
> 1.) Build and deploy the latest simple.war
> 2.) go the the tree2 (nice wrap) demo.
> 3.) click on the only rendered node.
> 4.) form submits, the action does fire, but tree2 is not rendered
> The tree will render however if you explictly set the id of the tree's parent element, a panelgrid. The same behavior holds true if the parent element is h:form (tree renders w/ explicit form@id, does not render w/out form@id).
> This behavior is not seen w/ builds of myFaces-all.jar before dec. 23. I also do not get this problem after checking out trunk, and doing a build after manually rolling back the latest change to UIViewRoot. This (harmless looking) change happened on the 23rd.
> This does not happen using client side toggle.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-978) tree2 affected by changes to UIViewRoot
Posted by "Dennis Byrne (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-978?page=comments#action_12361238 ]
Dennis Byrne commented on MYFACES-978:
--------------------------------------
I don't have a clue at this point ;) I have noticed that when @id is not specified for the parent, it gets an id on the first request and the tree is of course a child. On the second request, the id has a 'higher value' (as expected) but there is no longer a tree child (at least, during the render response phase). This explains why the tree is not rendered.
This does not happen w/ other controls. For example, commandLinks and outputText children are preserved across requests.
UIViewRoot looks good to me, but in an unrelated issue, maybe it could be changed to java.math.BigInteger? It seems silly to you or I but the use cases I see on mailing lists and forums sometimes are hilarious :)
> tree2 affected by changes to UIViewRoot
> ---------------------------------------
>
> Key: MYFACES-978
> URL: http://issues.apache.org/jira/browse/MYFACES-978
> Project: MyFaces
> Type: Bug
> Components: Tomahawk
> Versions: Nightly
> Environment: nightly builds from dec. 22, 23 - tomcate 5.5
> Reporter: Dennis Byrne
> Priority: Minor
>
> 1.) Build and deploy the latest simple.war
> 2.) go the the tree2 (nice wrap) demo.
> 3.) click on the only rendered node.
> 4.) form submits, the action does fire, but tree2 is not rendered
> The tree will render however if you explictly set the id of the tree's parent element, a panelgrid. The same behavior holds true if the parent element is h:form (tree renders w/ explicit form@id, does not render w/out form@id).
> This behavior is not seen w/ builds of myFaces-all.jar before dec. 23. I also do not get this problem after checking out trunk, and doing a build after manually rolling back the latest change to UIViewRoot. This (harmless looking) change happened on the 23rd.
> This does not happen using client side toggle.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira