You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Ho (Code Review)" <ge...@cloudera.org> on 2017/03/14 02:25:44 UTC
[Impala-ASF-CR] Remove some dead code.
Michael Ho has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6377
Change subject: Remove some dead code.
......................................................................
Remove some dead code.
Testing done: compiled Impala.
Change-Id: If890c2a2589148db38ea333a518dc1368dcd5459
---
D be/src/util/key-normalizer.h
D be/src/util/key-normalizer.inline.h
2 files changed, 0 insertions(+), 299 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/6377/1
--
To view, visit http://gerrit.cloudera.org:8080/6377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If890c2a2589148db38ea333a518dc1368dcd5459
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
[Impala-ASF-CR] Remove key-normalizer*.h which appear to be dead code at this point.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: Remove key-normalizer*.h which appear to be dead code at this point.
......................................................................
Patch Set 2:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/374/
--
To view, visit http://gerrit.cloudera.org:8080/6377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If890c2a2589148db38ea333a518dc1368dcd5459
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Remove key-normalizer*.h which appear to be dead code at this point.
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change.
Change subject: Remove key-normalizer*.h which appear to be dead code at this point.
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If890c2a2589148db38ea333a518dc1368dcd5459
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Remove key-normalizer*.h which appear to be dead code at this point.
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has submitted this change and it was merged.
Change subject: Remove key-normalizer*.h which appear to be dead code at this point.
......................................................................
Remove key-normalizer*.h which appear to be dead code at this point.
Testing done: compiled Impala.
Change-Id: If890c2a2589148db38ea333a518dc1368dcd5459
Reviewed-on: http://gerrit.cloudera.org:8080/6377
Tested-by: Impala Public Jenkins
Reviewed-by: Michael Ho <kw...@cloudera.com>
---
D be/src/util/key-normalizer.h
D be/src/util/key-normalizer.inline.h
2 files changed, 0 insertions(+), 299 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Michael Ho: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If890c2a2589148db38ea333a518dc1368dcd5459
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
[Impala-ASF-CR] Remove some dead code.
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: Remove some dead code.
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6377/1//COMMIT_MSG
Commit Message:
Line 7: Remove some dead code.
nit: just mention what it was
--
To view, visit http://gerrit.cloudera.org:8080/6377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If890c2a2589148db38ea333a518dc1368dcd5459
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] Remove key-normalizer*.h which appear to be dead code at this point.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: Remove key-normalizer*.h which appear to be dead code at this point.
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If890c2a2589148db38ea333a518dc1368dcd5459
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Remove key-normalizer*.h which appear to be dead code at this point.
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change.
Change subject: Remove key-normalizer*.h which appear to be dead code at this point.
......................................................................
Patch Set 2:
Carry Matt's +2 forward.
--
To view, visit http://gerrit.cloudera.org:8080/6377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If890c2a2589148db38ea333a518dc1368dcd5459
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Remove key-normalizer*.h which appear to be dead code at this point.
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Hello Matthew Jacobs,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6377
to look at the new patch set (#2).
Change subject: Remove key-normalizer*.h which appear to be dead code at this point.
......................................................................
Remove key-normalizer*.h which appear to be dead code at this point.
Testing done: compiled Impala.
Change-Id: If890c2a2589148db38ea333a518dc1368dcd5459
---
D be/src/util/key-normalizer.h
D be/src/util/key-normalizer.inline.h
2 files changed, 0 insertions(+), 299 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/6377/2
--
To view, visit http://gerrit.cloudera.org:8080/6377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If890c2a2589148db38ea333a518dc1368dcd5459
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>