You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by zh...@gmail.com on 2010/02/26 00:34:56 UTC

Add image/x-icon to Blacklisted types from encoding detection (issue224064)

Reviewers: shindig.remailer_gmail.com, johnfargo,

Description:



Please review this at http://codereview.appspot.com/224064/show

Affected files:
    
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponse.java


### Eclipse Workspace Patch 1.0
#P shindig-project
Index:  
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponse.java
===================================================================
---  
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponse.java	 
(revision 915473)
+++  
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponse.java	 
(working copy)
@@ -26,6 +26,7 @@
  import com.google.common.collect.Multimaps;
  import com.google.inject.Inject;
  import com.google.inject.name.Named;
+
  import org.apache.commons.lang.StringUtils;
  import org.apache.shindig.common.util.DateUtil;
  import org.apache.shindig.gadgets.encoding.EncodingDetector;
@@ -108,7 +109,7 @@
        "application/octet-stream", "application/ogg", "application/zip", "audio/mpeg",
        "audio/x-ms-wma", "audio/vnd.rn-realaudio", "audio/x-wav", "video/mpeg", "video/mp4",
        "video/quicktime", "video/x-ms-wmv", "video/x-flv", "video/flv",
-      "video/x-ms-asf", "application/pdf"
+      "video/x-ms-asf", "application/pdf", "image/x-icon"
    );

    // These HTTP status codes should always honor the HTTP status returned  
by the remote host. All