You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2025/07/16 17:16:36 UTC
[Impala-ASF-CR] IMPALA-13811: Deflake test insert overwrite base detection
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23180
Change subject: IMPALA-13811: Deflake test_insert_overwrite_base_detection
......................................................................
IMPALA-13811: Deflake test_insert_overwrite_base_detection
The test didn't wait in wait_for_finished_timeout() long
enough and ignored its return value, so it could continue
execution before the query was actually finished.
Change-Id: I339bd338cfd3873cc4892f012066034a6f7d4e12
---
M tests/query_test/test_acid.py
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/23180/1
--
To view, visit http://gerrit.cloudera.org:8080/23180
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I339bd338cfd3873cc4892f012066034a6f7d4e12
Gerrit-Change-Number: 23180
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
[Impala-ASF-CR] IMPALA-13811: Deflake test insert overwrite base detection
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23180 )
Change subject: IMPALA-13811: Deflake test_insert_overwrite_base_detection
......................................................................
IMPALA-13811: Deflake test_insert_overwrite_base_detection
The test didn't wait in wait_for_finished_timeout() long
enough and ignored its return value, so it could continue
execution before the query was actually finished.
Change-Id: I339bd338cfd3873cc4892f012066034a6f7d4e12
Reviewed-on: http://gerrit.cloudera.org:8080/23180
Reviewed-by: Riza Suminto <ri...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/query_test/test_acid.py
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Riza Suminto: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/23180
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I339bd338cfd3873cc4892f012066034a6f7d4e12
Gerrit-Change-Number: 23180
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13811: Deflake test insert overwrite base detection
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23180 )
Change subject: IMPALA-13811: Deflake test_insert_overwrite_base_detection
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12192/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/23180
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I339bd338cfd3873cc4892f012066034a6f7d4e12
Gerrit-Change-Number: 23180
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Jul 2025 20:16:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13811: Deflake test insert overwrite base detection
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23180 )
Change subject: IMPALA-13811: Deflake test_insert_overwrite_base_detection
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23180
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I339bd338cfd3873cc4892f012066034a6f7d4e12
Gerrit-Change-Number: 23180
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Jul 2025 18:42:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13811: Deflake test insert overwrite base detection
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23180 )
Change subject: IMPALA-13811: Deflake test_insert_overwrite_base_detection
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19896/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23180
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I339bd338cfd3873cc4892f012066034a6f7d4e12
Gerrit-Change-Number: 23180
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Jul 2025 17:43:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13811: Deflake test insert overwrite base detection
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23180 )
Change subject: IMPALA-13811: Deflake test_insert_overwrite_base_detection
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/23180
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I339bd338cfd3873cc4892f012066034a6f7d4e12
Gerrit-Change-Number: 23180
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Jul 2025 02:45:58 +0000
Gerrit-HasComments: No