You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@synapse.apache.org by "Eric Hubert (JIRA)" <ji...@apache.org> on 2009/03/08 22:57:56 UTC
[jira] Created: (SYNAPSE-514) Enhance HessianMessageBuilder with
fault detection
Enhance HessianMessageBuilder with fault detection
--------------------------------------------------
Key: SYNAPSE-514
URL: https://issues.apache.org/jira/browse/SYNAPSE-514
Project: Synapse
Issue Type: Improvement
Components: Extension Mediators
Affects Versions: 1.3
Reporter: Eric Hubert
Priority: Minor
Fix For: 1.3
Currently there is no way to detect Hessian faults in the mediation. For most other message formats this has already been implemented. Once a fault is detected a property indicating the fault is stored inside the Axis message context.
The attached patch add the same behavior for binary Hessian messages. It extends the existing HessianMessageBuilder. Additionally the patch includes unit tests to test the added functionality as well as the existing one. So far there were no unit tests.
The unit test need some binary hessian messages as test resources. I included them in the patch to ease the review but do think it might make more sense to put them in the svn repo individually. So I'll attach those files separately as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
Re: [jira] Commented: (SYNAPSE-514) Enhance HessianMessageBuilder
with fault detection
Posted by Ruwan Linton <ru...@gmail.com>.
Yeah I got that, and thanks.
Ruwan
On Mon, Mar 9, 2009 at 1:59 PM, Eric Hubert (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/SYNAPSE-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680085#action_12680085]
>
> Eric Hubert commented on SYNAPSE-514:
> -------------------------------------
>
> Hi Ruwan,
>
> the HessianMessageFormatter is not affected from that change as there is
> not differentiation between "normal" hessian responses and "fault" hessian
> responses, which is perfectly fine. The only differentation made is for the
> case that a SOAP fault (most likely created by the FaultMediator) shall be
> "formatted" as a hessian fault. For this case the HessianMessageFormatter
> currently constructs a Hessian fault message.
>
> Anyway the HessianMessageFormatter could also get some minor code cleanups
> and a unit test. I will do so and submit another patch soon.
>
> > Enhance HessianMessageBuilder with fault detection
> > --------------------------------------------------
> >
> > Key: SYNAPSE-514
> > URL: https://issues.apache.org/jira/browse/SYNAPSE-514
> > Project: Synapse
> > Issue Type: Improvement
> > Components: Extension Mediators
> > Affects Versions: 1.2
> > Reporter: Eric Hubert
> > Assignee: Ruwan Linton
> > Priority: Minor
> > Fix For: 1.3
> >
> > Attachments: HessianMessageBuilder.patch, restresources.zip
> >
> >
> > Currently there is no way to detect Hessian faults in the mediation. For
> most other message formats this has already been implemented. Once a fault
> is detected a property indicating the fault is stored inside the Axis
> message context.
> > The attached patch add the same behavior for binary Hessian messages. It
> extends the existing HessianMessageBuilder. Additionally the patch includes
> unit tests to test the added functionality as well as the existing one. So
> far there were no unit tests.
> > The unit test need some binary hessian messages as test resources. I
> included them in the patch to ease the review but do think it might make
> more sense to put them in the svn repo individually. So I'll attach those
> files separately as well.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
> For additional commands, e-mail: dev-help@synapse.apache.org
>
>
--
Ruwan Linton
http://wso2.org - "Oxygenating the Web Services Platform"
http://ruwansblog.blogspot.com/
[jira] Assigned: (SYNAPSE-514) Enhance HessianMessageBuilder with
fault detection
Posted by "Ruwan Linton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ruwan Linton reassigned SYNAPSE-514:
------------------------------------
Assignee: Ruwan Linton
> Enhance HessianMessageBuilder with fault detection
> --------------------------------------------------
>
> Key: SYNAPSE-514
> URL: https://issues.apache.org/jira/browse/SYNAPSE-514
> Project: Synapse
> Issue Type: Improvement
> Components: Extension Mediators
> Affects Versions: 1.3
> Reporter: Eric Hubert
> Assignee: Ruwan Linton
> Priority: Minor
> Fix For: 1.3
>
> Attachments: HessianMessageBuilder.patch, restresources.zip
>
>
> Currently there is no way to detect Hessian faults in the mediation. For most other message formats this has already been implemented. Once a fault is detected a property indicating the fault is stored inside the Axis message context.
> The attached patch add the same behavior for binary Hessian messages. It extends the existing HessianMessageBuilder. Additionally the patch includes unit tests to test the added functionality as well as the existing one. So far there were no unit tests.
> The unit test need some binary hessian messages as test resources. I included them in the patch to ease the review but do think it might make more sense to put them in the svn repo individually. So I'll attach those files separately as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Commented: (SYNAPSE-514) Enhance HessianMessageBuilder with
fault detection
Posted by "Ruwan Linton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680040#action_12680040 ]
Ruwan Linton commented on SYNAPSE-514:
--------------------------------------
well, I think that is already handled because it is a hessian message itself isn't it?
> Enhance HessianMessageBuilder with fault detection
> --------------------------------------------------
>
> Key: SYNAPSE-514
> URL: https://issues.apache.org/jira/browse/SYNAPSE-514
> Project: Synapse
> Issue Type: Improvement
> Components: Extension Mediators
> Affects Versions: 1.2
> Reporter: Eric Hubert
> Assignee: Ruwan Linton
> Priority: Minor
> Fix For: 1.3
>
> Attachments: HessianMessageBuilder.patch, restresources.zip
>
>
> Currently there is no way to detect Hessian faults in the mediation. For most other message formats this has already been implemented. Once a fault is detected a property indicating the fault is stored inside the Axis message context.
> The attached patch add the same behavior for binary Hessian messages. It extends the existing HessianMessageBuilder. Additionally the patch includes unit tests to test the added functionality as well as the existing one. So far there were no unit tests.
> The unit test need some binary hessian messages as test resources. I included them in the patch to ease the review but do think it might make more sense to put them in the svn repo individually. So I'll attach those files separately as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Commented: (SYNAPSE-514) Enhance HessianMessageBuilder with
fault detection
Posted by "Eric Hubert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680085#action_12680085 ]
Eric Hubert commented on SYNAPSE-514:
-------------------------------------
Hi Ruwan,
the HessianMessageFormatter is not affected from that change as there is not differentiation between "normal" hessian responses and "fault" hessian responses, which is perfectly fine. The only differentation made is for the case that a SOAP fault (most likely created by the FaultMediator) shall be "formatted" as a hessian fault. For this case the HessianMessageFormatter currently constructs a Hessian fault message.
Anyway the HessianMessageFormatter could also get some minor code cleanups and a unit test. I will do so and submit another patch soon.
> Enhance HessianMessageBuilder with fault detection
> --------------------------------------------------
>
> Key: SYNAPSE-514
> URL: https://issues.apache.org/jira/browse/SYNAPSE-514
> Project: Synapse
> Issue Type: Improvement
> Components: Extension Mediators
> Affects Versions: 1.2
> Reporter: Eric Hubert
> Assignee: Ruwan Linton
> Priority: Minor
> Fix For: 1.3
>
> Attachments: HessianMessageBuilder.patch, restresources.zip
>
>
> Currently there is no way to detect Hessian faults in the mediation. For most other message formats this has already been implemented. Once a fault is detected a property indicating the fault is stored inside the Axis message context.
> The attached patch add the same behavior for binary Hessian messages. It extends the existing HessianMessageBuilder. Additionally the patch includes unit tests to test the added functionality as well as the existing one. So far there were no unit tests.
> The unit test need some binary hessian messages as test resources. I included them in the patch to ease the review but do think it might make more sense to put them in the svn repo individually. So I'll attach those files separately as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Commented: (SYNAPSE-514) Enhance HessianMessageBuilder with
fault detection
Posted by "Ruwan Linton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680024#action_12680024 ]
Ruwan Linton commented on SYNAPSE-514:
--------------------------------------
Eric, I think we need to improve the HessianMessageFormatter to serialize these hessian faults into the wire, isn't it?
Thanks,
Ruwan
> Enhance HessianMessageBuilder with fault detection
> --------------------------------------------------
>
> Key: SYNAPSE-514
> URL: https://issues.apache.org/jira/browse/SYNAPSE-514
> Project: Synapse
> Issue Type: Improvement
> Components: Extension Mediators
> Affects Versions: 1.2
> Reporter: Eric Hubert
> Assignee: Ruwan Linton
> Priority: Minor
> Fix For: 1.3
>
> Attachments: HessianMessageBuilder.patch, restresources.zip
>
>
> Currently there is no way to detect Hessian faults in the mediation. For most other message formats this has already been implemented. Once a fault is detected a property indicating the fault is stored inside the Axis message context.
> The attached patch add the same behavior for binary Hessian messages. It extends the existing HessianMessageBuilder. Additionally the patch includes unit tests to test the added functionality as well as the existing one. So far there were no unit tests.
> The unit test need some binary hessian messages as test resources. I included them in the patch to ease the review but do think it might make more sense to put them in the svn repo individually. So I'll attach those files separately as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Updated: (SYNAPSE-514) Enhance HessianMessageBuilder with
fault detection
Posted by "Ruwan Linton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ruwan Linton updated SYNAPSE-514:
---------------------------------
Affects Version/s: (was: 1.3)
1.2
The affected version has to be 1.2 because this is going to be fixed in the 1.3 once we commit in this patch
> Enhance HessianMessageBuilder with fault detection
> --------------------------------------------------
>
> Key: SYNAPSE-514
> URL: https://issues.apache.org/jira/browse/SYNAPSE-514
> Project: Synapse
> Issue Type: Improvement
> Components: Extension Mediators
> Affects Versions: 1.2
> Reporter: Eric Hubert
> Assignee: Ruwan Linton
> Priority: Minor
> Fix For: 1.3
>
> Attachments: HessianMessageBuilder.patch, restresources.zip
>
>
> Currently there is no way to detect Hessian faults in the mediation. For most other message formats this has already been implemented. Once a fault is detected a property indicating the fault is stored inside the Axis message context.
> The attached patch add the same behavior for binary Hessian messages. It extends the existing HessianMessageBuilder. Additionally the patch includes unit tests to test the added functionality as well as the existing one. So far there were no unit tests.
> The unit test need some binary hessian messages as test resources. I included them in the patch to ease the review but do think it might make more sense to put them in the svn repo individually. So I'll attach those files separately as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Updated: (SYNAPSE-514) Enhance HessianMessageBuilder with
fault detection
Posted by "Eric Hubert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Hubert updated SYNAPSE-514:
--------------------------------
Attachment: restresources.zip
HessianMessageBuilder.patch
> Enhance HessianMessageBuilder with fault detection
> --------------------------------------------------
>
> Key: SYNAPSE-514
> URL: https://issues.apache.org/jira/browse/SYNAPSE-514
> Project: Synapse
> Issue Type: Improvement
> Components: Extension Mediators
> Affects Versions: 1.3
> Reporter: Eric Hubert
> Priority: Minor
> Fix For: 1.3
>
> Attachments: HessianMessageBuilder.patch, restresources.zip
>
>
> Currently there is no way to detect Hessian faults in the mediation. For most other message formats this has already been implemented. Once a fault is detected a property indicating the fault is stored inside the Axis message context.
> The attached patch add the same behavior for binary Hessian messages. It extends the existing HessianMessageBuilder. Additionally the patch includes unit tests to test the added functionality as well as the existing one. So far there were no unit tests.
> The unit test need some binary hessian messages as test resources. I included them in the patch to ease the review but do think it might make more sense to put them in the svn repo individually. So I'll attach those files separately as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Resolved: (SYNAPSE-514) Enhance HessianMessageBuilder with
fault detection
Posted by "Ruwan Linton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ruwan Linton resolved SYNAPSE-514.
----------------------------------
Resolution: Fixed
Committed the patch and fixed on the trunk. Thanks Eric for the contribution
> Enhance HessianMessageBuilder with fault detection
> --------------------------------------------------
>
> Key: SYNAPSE-514
> URL: https://issues.apache.org/jira/browse/SYNAPSE-514
> Project: Synapse
> Issue Type: Improvement
> Components: Extension Mediators
> Affects Versions: 1.2
> Reporter: Eric Hubert
> Assignee: Ruwan Linton
> Priority: Minor
> Fix For: 1.3
>
> Attachments: HessianMessageBuilder.patch, restresources.zip
>
>
> Currently there is no way to detect Hessian faults in the mediation. For most other message formats this has already been implemented. Once a fault is detected a property indicating the fault is stored inside the Axis message context.
> The attached patch add the same behavior for binary Hessian messages. It extends the existing HessianMessageBuilder. Additionally the patch includes unit tests to test the added functionality as well as the existing one. So far there were no unit tests.
> The unit test need some binary hessian messages as test resources. I included them in the patch to ease the review but do think it might make more sense to put them in the svn repo individually. So I'll attach those files separately as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org