You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/05/16 18:38:03 UTC
[GitHub] [maven-resolver-ant-tasks] breun opened a new pull request #6: WIP: [MRESOLVER-181] Upgrade Ant to 1.9.15
breun opened a new pull request #6:
URL: https://github.com/apache/maven-resolver-ant-tasks/pull/6
Submitted by: Nils Breunese
o Updated to Ant 1.9.15
o Replaced use of BuildFileTest with BuildFileRule
o Integration tests are not passing yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver-ant-tasks] slachiewicz commented on pull request #6: WIP: [MRESOLVER-181] Upgrade Ant to 1.9.15
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #6:
URL: https://github.com/apache/maven-resolver-ant-tasks/pull/6#issuecomment-842429102
hi, looks like issue with 1.9x version, not about test refactoring: https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-resolver-ant-tasks/job/MRESOLVER-181/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver-ant-tasks] slachiewicz commented on pull request #6: WIP: [MRESOLVER-181] Upgrade Ant to 1.9.15
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #6:
URL: https://github.com/apache/maven-resolver-ant-tasks/pull/6#issuecomment-842429102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver-ant-tasks] cstamas commented on pull request #6: WIP: [MRESOLVER-181] Upgrade Ant to 1.9.15
Posted by GitBox <gi...@apache.org>.
cstamas commented on pull request #6:
URL: https://github.com/apache/maven-resolver-ant-tasks/pull/6#issuecomment-968372176
Pushed changes I did (partially based on changes in this PR), please reuse https://github.com/apache/maven-resolver-ant-tasks/pull/13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver-ant-tasks] asfgit closed pull request #6: WIP: [MRESOLVER-181] Upgrade Ant to 1.9.15
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #6:
URL: https://github.com/apache/maven-resolver-ant-tasks/pull/6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver-ant-tasks] michael-o edited a comment on pull request #6: WIP: [MRESOLVER-181] Upgrade Ant to 1.9.15
Posted by GitBox <gi...@apache.org>.
michael-o edited a comment on pull request #6:
URL: https://github.com/apache/maven-resolver-ant-tasks/pull/6#issuecomment-968331562
Tried for two more hours, no avail. I don't see the actual issue here :(
If you run Ant directly, it works, but the locks up with the `ResolveTest` :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver-ant-tasks] michael-o commented on pull request #6: WIP: [MRESOLVER-181] Upgrade Ant to 1.9.15
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #6:
URL: https://github.com/apache/maven-resolver-ant-tasks/pull/6#issuecomment-917611100
@breun I can confirm this, sadly. I guess one needs to debug this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver-ant-tasks] breun commented on pull request #6: WIP: [MRESOLVER-181] Upgrade Ant to 1.9.15
Posted by GitBox <gi...@apache.org>.
breun commented on pull request #6:
URL: https://github.com/apache/maven-resolver-ant-tasks/pull/6#issuecomment-842444461
I see this at https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-resolver-ant-tasks/job/MRESOLVER-181/1/console:
```
[INFO] [junit] Testcase: warning(junit.framework.TestSuite$1): FAILED
[INFO] [junit] No tests found in org.apache.maven.resolver.internal.ant.ProjectWorkspaceReaderTest
[INFO] [junit] junit.framework.AssertionFailedError: No tests found in org.apache.maven.resolver.internal.ant.ProjectWorkspaceReaderTest
```
Both my IDE and I find 3 JUnit tests in that class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver-ant-tasks] cstamas commented on pull request #6: WIP: [MRESOLVER-181] Upgrade Ant to 1.9.15
Posted by GitBox <gi...@apache.org>.
cstamas commented on pull request #6:
URL: https://github.com/apache/maven-resolver-ant-tasks/pull/6#issuecomment-968366655
To me also it runs all until ResolveTest where it deadlocks, Reason is:
1- DefaultAntLogger uses PrintStream (that sync on this/self)
2- AntBuildsTest now uses BuildFileRule that in turn executes all the goals withing synchronized block (on system out)
3- resolver by default resolve on MT
Simply put: test is nested in such way, that multi threaded logging will deadlock, and resolver by default does exactly that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver-ant-tasks] breun commented on pull request #6: WIP: [MRESOLVER-181] Upgrade Ant to 1.9.15
Posted by GitBox <gi...@apache.org>.
breun commented on pull request #6:
URL: https://github.com/apache/maven-resolver-ant-tasks/pull/6#issuecomment-842444461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver-ant-tasks] michael-o commented on pull request #6: WIP: [MRESOLVER-181] Upgrade Ant to 1.9.15
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #6:
URL: https://github.com/apache/maven-resolver-ant-tasks/pull/6#issuecomment-968331562
Tried for two more hours, no avail. I don't see the actual issue here :-(
If you run Ant directly, it works, but the locks up with the `ResolveTest` :-(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver-ant-tasks] breun commented on pull request #6: WIP: [MRESOLVER-181] Upgrade Ant to 1.9.15
Posted by GitBox <gi...@apache.org>.
breun commented on pull request #6:
URL: https://github.com/apache/maven-resolver-ant-tasks/pull/6#issuecomment-842498904
Running `mvn -X -Prun-its verify` shows this:
```
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:3.0.0:run (smoke-test) on project maven-resolver-ant-tasks: An Ant BuildException has occured: The following error occurred while executing this line:
[ERROR] /Users/breun/Projects/maven-resolver-ant-tasks/build.xml:98: java.lang.NoSuchMethodError: org.apache.tools.ant.util.FileUtils.createTempFile(Lorg/apache/tools/ant/Project;Ljava/lang/String;Ljava/lang/String;Ljava/io/File;ZZ)Ljava/io/File;
[ERROR] around Ant part ...<ant antfile="build.xml" />... @ 4:32 in /Users/breun/Projects/maven-resolver-ant-tasks/target/antrun/build-main.xml
```
I'm afraid I don't know what code is trying to execute `FileUtils.createTempFile(Project, String, String, File)`, but Ant 1.9.15's `FileUtils` indeed only has these `createTempFile` methods:
* `public File createTempFile(final Project project, String prefix, String suffix, final File parentDir, final boolean deleteOnExit, final boolean createFile)`
* `public File createTempFile(String prefix, String suffix, File parentDir)` (deprecated "since ant 1.7.1 use createTempFile(Project, String, String, File, boolean, boolean) instead")
* `public File createTempFile(String prefix, String suffix, File parentDir, boolean deleteOnExit, boolean createFile)` (deprecated "since Ant 1.9.15 use createTempFile(Project, String, String, File, boolean, boolean) instead")
* `public File createTempFile(String prefix, String suffix, File parentDir, boolean deleteOnExit)` (deprecated "since ant 1.7.1 use createTempFile(Project, String, String, File, boolean, boolean) instead")
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver-ant-tasks] michael-o commented on pull request #6: WIP: [MRESOLVER-181] Upgrade Ant to 1.9.15
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #6:
URL: https://github.com/apache/maven-resolver-ant-tasks/pull/6#issuecomment-968309577
I am currently stuck at:
```
[INFO] [junit] Testsuite: org.apache.maven.resolver.internal.ant.DeployTest
[INFO] [junit] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0,005 sec
[INFO] [junit]
[INFO] [junit] Testcase: warning(junit.framework.TestSuite$1): FAILED
[INFO] [junit] No tests found in org.apache.maven.resolver.internal.ant.DeployTest
[INFO] [junit] junit.framework.AssertionFailedError: No tests found in org.apache.maven.resolver.internal.ant.DeployTest
[INFO] [junit]
[INFO] [junit]
[DEBUG] [ant] Exiting D:\Entwicklung\Projekte\maven-resolver-ant-tasks\build.xml.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver-ant-tasks] slachiewicz commented on pull request #6: WIP: [MRESOLVER-181] Upgrade Ant to 1.9.15
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #6:
URL: https://github.com/apache/maven-resolver-ant-tasks/pull/6#issuecomment-842447644
Same on my side, if You run Maven with -X we can see more details, but I have no clue why it is not able to find JunitAdapter class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver-ant-tasks] michael-o commented on pull request #6: WIP: [MRESOLVER-181] Upgrade Ant to 1.9.15
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #6:
URL: https://github.com/apache/maven-resolver-ant-tasks/pull/6#issuecomment-968332362
I am included to disable this test for now and continue with the PR until someone can solve this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org