You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/04/22 18:25:38 UTC

[GitHub] [geode] bschuchardt commented on a change in pull request #6360: GEODE-9180: heartbeat producer logs a warning when it misses beats

bschuchardt commented on a change in pull request #6360:
URL: https://github.com/apache/geode/pull/6360#discussion_r618641647



##########
File path: geode-membership/src/integrationTest/java/org/apache/geode/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java
##########
@@ -999,6 +1000,52 @@ public void testDoTCPCheckMemberWithUnkownStatus() throws Exception {
     executeTestDoTCPCheck(GMSHealthMonitor.ERROR + 100, false);
   }
 
+  @Test
+  public void heartbeatOversleepCausesWarning() {
+    testHeartbeatSleepScenario(period -> 2 * period + 1,

Review comment:
       maybe replace the "2"s in this test with the logical-interval constant from GMSHealthMonitor




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org