[jira] [Comment Edited] (LOG4J2-1329) API change: let Message.getFormattedMessage() return CharSequence instead of String

["Mikael Ståldal (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LOG4J2-1329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15215667#comment-15215667 ] 

Mikael Ståldal edited comment on LOG4J2-1329 at 3/29/16 8:20 AM:
-----------------------------------------------------------------

GelfLayout do have its own buffer, but the issue is that it needs to escape the message (replace " with \" etc) before appending it to the buffer.


was (Author: mikaelstaldal):
GelfLayout do have its own buffer, but the issue is that it need to escape the message (replace " with \" etc) before appending it to the buffer.

> API change: let Message.getFormattedMessage() return CharSequence instead of String
> -----------------------------------------------------------------------------------
>
>                 Key: LOG4J2-1329
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1329
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: API
>    Affects Versions: 2.5
>            Reporter: Remko Popma
>
> I propose that we change {{Message.getFormattedMessage()}} to return a {{CharSequence}} instead of a String.
> I believe this change would be backwards compatible (all Message implementations that return a String will work as is), and it opens the way
> for zero-GC Message implementations to return a cached StringBuilder as Mikael [suggested on the log4j-dev mailing list|http://mail-archives.apache.org/mod_mbox/logging-log4j-dev/201603.mbox/%3CCAAFrFhSs4EqjOERwHObKAZP4wjGWeiCET1nyE1FVndYdePk2yw%40mail.gmail.com%3E].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org