You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/19 17:08:45 UTC

[GitHub] [airflow] marcusianlevine commented on a change in pull request #15308: Fix used_group_ids in partial_subset (#13700)

marcusianlevine commented on a change in pull request #15308:
URL: https://github.com/apache/airflow/pull/15308#discussion_r616027987



##########
File path: airflow/models/dag.py
##########
@@ -1504,6 +1504,8 @@ def filter_task_group(group, parent_group):
                 if isinstance(child, BaseOperator):
                     if child.task_id in dag.task_dict:
                         copied.children[child.task_id] = dag.task_dict[child.task_id]
+                    else:
+                        copied.used_group_ids.discard(child.task_id)

Review comment:
       I added another assert to an existing test of the `sub_dag` function, but the quarantined tests are failing (not sure if that's a problem)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org