You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tooling.apache.org by "andrewmusselman (via GitHub)" <gi...@apache.org> on 2026/02/25 18:45:40 UTC
[I] GitHub workflow arguments lack key/value validation (tooling-trusted-releases)
andrewmusselman opened a new issue, #771:
URL: https://github.com/apache/tooling-trusted-releases/issues/771
**Source:** ASVS 2.2.1 Finding HIGH-004
**CWE:** CWE-20 (Improper Input Validation)
**Location:** `atr/tasks/gha.py`, lines 51–67
#### Description
The `arguments` dictionary from workflow configuration is spread directly into GitHub workflow dispatch inputs using `**args.arguments` without validating keys or values. An attacker could inject arbitrary workflow input keys that override security-sensitive values like `atr-id`, `asf-uid`, or `project`.
#### Affected Code
```python
payload = {
"ref": "main",
"inputs": {
"atr-id": unique_id,
"asf-uid": args.asf_uid,
"project": args.project_name,
**args.arguments, # Unvalidated dict spread — could override keys above
},
}
```
#### Recommendation
- Take out extra keywords
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org
Re: [I] GitHub workflow arguments lack key/value validation (tooling-trusted-releases)
Posted by "alitheg (via GitHub)" <gi...@apache.org>.
alitheg closed issue #771: GitHub workflow arguments lack key/value validation
URL: https://github.com/apache/tooling-trusted-releases/issues/771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org