You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "ashahba (via GitHub)" <gi...@apache.org> on 2025/06/07 06:09:00 UTC

[PR] [GLUTEN-9960] Remove hardcoded path to cmake-format [incubator-gluten]

ashahba opened a new pull request, #9907:
URL: https://github.com/apache/incubator-gluten/pull/9907

   ## What changes were proposed in this pull request?
   
   `cmake-format` is used from a hardcoded path within Github action `ch_code_style.yml` like this:
   ```
   /github/home/.local/bin/cmake-format ...
   ```
   
   Fixes: #9906 
   
   ## How was this patch tested?
   It was tested locally:
   ```
    WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
   [CH Backend Code style checks/CH CMake Format Check]   ✅  Success - Main Install tools [27.824740074s]
   [CH Backend Code style checks/CH CMake Format Check]   ⚙  ::add-path:: /root/.local/bin
   [CH Backend Code style checks/CH CMake Format Check] ⭐ Run Main actions/checkout@v4
   [CH Backend Code style checks/CH CMake Format Check]   🐳  docker cp src=/localdisk/ashahba/source_code/incubator-gluten/. dst=/localdisk/ashahba/source_code/incubator-gluten
   [CH Backend Code style checks/CH CMake Format Check]   ✅  Success - Main actions/checkout@v4 [1.438931312s]
   [CH Backend Code style checks/CH CMake Format Check] ⭐ Run Main Check CMake format
   [CH Backend Code style checks/CH CMake Format Check]   🐳  docker exec cmd=[sh -e /var/run/act/workflow/2.sh] user= workdir=
   | No CMake format issue.
   [CH Backend Code style checks/CH CMake Format Check]   ✅  Success - Main Check CMake format [4.938387058s]
   [CH Backend Code style checks/CH CMake Format Check] ⭐ Run Complete job
   [CH Backend Code style checks/CH CMake Format Check] Cleaning up container for job CH CMake Format Check
   [CH Backend Code style checks/CH CMake Format Check]   ✅  Success - Complete job
   [CH Backend Code style checks/CH CMake Format Check] 🏁  Job succeeded
   ```
   
   (Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
   N/A
   
   (If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
   N/A
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org

Re: [PR] [GLUTEN-9960][CH] Remove hardcoded path to cmake-format [incubator-gluten]

Posted by "surnaik (via GitHub)" <gi...@apache.org>.
surnaik commented on PR #9907:
URL: https://github.com/apache/incubator-gluten/pull/9907#issuecomment-2956490353

   Thanks for the fix! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org

Re: [PR] [GLUTEN-9960][CH] Remove hardcoded path to cmake-format [incubator-gluten]

Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE merged PR #9907:
URL: https://github.com/apache/incubator-gluten/pull/9907


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org

Re: [PR] [GLUTEN-9960] Remove hardcoded path to cmake-format [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9907:
URL: https://github.com/apache/incubator-gluten/pull/9907#issuecomment-2951925745

   https://github.com/apache/incubator-gluten/issues/9960


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org