You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Nixon Rodrigues <ni...@freestoneinfotech.com> on 2020/10/07 05:15:46 UTC
Review Request 72937: ATLAS-3971 :- Move authorization check for
Business Metadata def before type exist check
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72937/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, Pinal Shah, and Sarath Subramanian.
Bugs: ATLAS-3971
https://issues.apache.org/jira/browse/ATLAS-3971
Repository: atlas
Description
-------
This patch moves authorization check for Business Metadata def before type exist check, so that end-user is only aware that a duplicate type creation is being attempted if he is authorized to.
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasBusinessMetadataDefStoreV2.java 23964f414
Diff: https://reviews.apache.org/r/72937/diff/1/
Testing
-------
Test duplicate Business Metadata def creation with authorized and unauthorized creation
Thanks,
Nixon Rodrigues
Re: Review Request 72937: ATLAS-3971 :- Move authorization check for
Business Metadata def before type exist check
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72937/#review221998
-----------------------------------------------------------
Ship it!
Ship It!
- Ashutosh Mestry
On Oct. 7, 2020, 5:15 a.m., Nixon Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72937/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2020, 5:15 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, Pinal Shah, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3971
> https://issues.apache.org/jira/browse/ATLAS-3971
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This patch moves authorization check for Business Metadata def before type exist check, so that end-user is only aware that a duplicate type creation is being attempted if he is authorized to.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasBusinessMetadataDefStoreV2.java 23964f414
>
>
> Diff: https://reviews.apache.org/r/72937/diff/1/
>
>
> Testing
> -------
>
> Test duplicate Business Metadata def creation with authorized and unauthorized creation
>
>
> Thanks,
>
> Nixon Rodrigues
>
>