[GitHub] [ozone] szetszwo commented on a diff in pull request #3403: HDDS-6732. Follower SCM crashed during snapshot installation.

[GitBox <gi...@apache.org>]

szetszwo commented on code in PR #3403:
URL: https://github.com/apache/ozone/pull/3403#discussion_r871178905


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMStateMachine.java:
##########
@@ -133,6 +133,15 @@ public CompletableFuture<Message> applyTransaction(
       final TransactionContext trx) {
     final CompletableFuture<Message> applyTransactionFuture =
         new CompletableFuture<>();
+    if (getLifeCycleState().isPausingOrPaused()) {
+      // Statemachine is installation snapshot. Discard any request.

Review Comment:
   @ChenSammi , SCM implements notifyInstallSnapshotFromLeader(..).  When the leader does not have the log entries, it sends a install snapshot notification to the follower.  Therefore, it cannot have any appendEntries calls during snapshot installation.  Are we sure the follower is installing a snapshot when it crashes?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org