You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by "Paul J. Reder" <re...@remulak.net> on 2008/01/18 17:40:57 UTC

[Fwd: Re: [Patch]: Add a couple of cases to the apr_ldap_set_option function.]

Any takers?

I'm still hoping to get this reviewed by someone and have it committed to
APR (since I don't have karma for that) so I can commit the Apache portion
to trunk.

Thanks,

Paul J. Reder

-------- Original Message --------
Subject: [Fwd: Re: [Patch]: Add a couple of cases to the apr_ldap_set_option function.]
Date: Wed, 19 Dec 2007 22:41:10 -0500
From: Paul J. Reder <re...@remulak.net>
To: APR dev list. <de...@apr.apache.org>

Just in case it would help in evaluating these APR changes this is the
link to the Apache-trunk code, which uses these APR changes, that I'm
waiting to commit...

http://people.apache.org/~rederpj/Apache-trunk_rebind.diff

Thanks,

Paul J. Reder

-------- Original Message --------
Subject: Re: [Patch]: Add a couple of cases to the apr_ldap_set_option function.
Date: Fri, 14 Dec 2007 18:57:17 -0500
From: Paul J. Reder <re...@remulak.net>
To: APR dev list. <de...@apr.apache.org>
References: <47...@remulak.net>

Brad confirmed that this should work for Novell. My pass through the
limited Solaris docs I was able find seemed to indicate this should work.

http://people.apache.org/~rederpj/apr-util-ldap.diff

Any more reviews? Anyone to commit it?

I was hoping to get this committed so I could commit the Apache trunk
code that uses this before I go on vacation next week.

Thanks again,

Paul J. Reder wrote:
> In keeping with the APR concept of hiding LDAP differences, I added a 
> couple
> of cases to the apr_ldap_set_option function. One of the cases has 
> differences
> between at least the openLDAP and Tivoli SDKs so I added both of them for
> consistency and to handle possible differences in other SDKs.
> 
> Folks who know the other SDKs should check if any #ifs need to be added
> to these cases for any of the other SDKs.
> 
> Once someone commits this patch I will be able to commit the Apache portion
> of the rebind code.

-- 
Paul J. Reder
-----------------------------------------------------------
"The strength of the Constitution lies entirely in the determination of each
citizen to defend it.  Only if every single citizen feels duty bound to do
his share in this defense are the constitutional rights secure."
-- Albert Einstein



-- 
Paul J. Reder
-----------------------------------------------------------
"The strength of the Constitution lies entirely in the determination of each
citizen to defend it.  Only if every single citizen feels duty bound to do
his share in this defense are the constitutional rights secure."
-- Albert Einstein



-- 
Paul J. Reder
-----------------------------------------------------------
"The strength of the Constitution lies entirely in the determination of each
citizen to defend it.  Only if every single citizen feels duty bound to do
his share in this defense are the constitutional rights secure."
-- Albert Einstein


[Fwd: Re: [Patch]: Add a couple of cases to the apr_ldap_set_option function.]

Posted by Brad Nicholes <bn...@novell.com>.
Committed.


>>> On Fri, Jan 18, 2008 at  9:40 AM, in message <47...@remulak.net>,
"Paul J. Reder" <re...@remulak.net> wrote: 

> Any takers?
> 
> I'm still hoping to get this reviewed by someone and have it committed to
> APR (since I don't have karma for that) so I can commit the Apache portion
> to trunk.
> 
> Thanks,
> 
> Paul J. Reder
> 
> -------- Original Message --------
> Subject: [Fwd: Re: [Patch]: Add a couple of cases to the apr_ldap_set_option 
> function.]
> Date: Wed, 19 Dec 2007 22:41:10 -0500
> From: Paul J. Reder <re...@remulak.net>
> To: APR dev list. <de...@apr.apache.org>
> 
> Just in case it would help in evaluating these APR changes this is the
> link to the Apache-trunk code, which uses these APR changes, that I'm
> waiting to commit...
> 
> http://people.apache.org/~rederpj/Apache-trunk_rebind.diff
> 
> Thanks,
> 
> Paul J. Reder
> 
> -------- Original Message --------
> Subject: Re: [Patch]: Add a couple of cases to the apr_ldap_set_option 
> function.
> Date: Fri, 14 Dec 2007 18:57:17 -0500
> From: Paul J. Reder <re...@remulak.net>
> To: APR dev list. <de...@apr.apache.org>
> References: <47...@remulak.net>
> 
> Brad confirmed that this should work for Novell. My pass through the
> limited Solaris docs I was able find seemed to indicate this should work.
> 
> http://people.apache.org/~rederpj/apr-util-ldap.diff
> 
> Any more reviews? Anyone to commit it?
> 
> I was hoping to get this committed so I could commit the Apache trunk
> code that uses this before I go on vacation next week.
> 
> Thanks again,
> 
> Paul J. Reder wrote:
>> In keeping with the APR concept of hiding LDAP differences, I added a 
>> couple
>> of cases to the apr_ldap_set_option function. One of the cases has 
>> differences
>> between at least the openLDAP and Tivoli SDKs so I added both of them for
>> consistency and to handle possible differences in other SDKs.
>> 
>> Folks who know the other SDKs should check if any #ifs need to be added
>> to these cases for any of the other SDKs.
>> 
>> Once someone commits this patch I will be able to commit the Apache portion
>> of the rebind code.