You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "Omega359 (via GitHub)" <gi...@apache.org> on 2024/10/16 15:09:51 UTC
[PR] Add regexp_count function [datafusion]
Omega359 opened a new pull request, #12970:
URL: https://github.com/apache/datafusion/pull/12970
## Which issue does this PR close?
Closes #12079 and part of #11946. Followup to PR #12080 by #[xinlifoobar](https://github.com/xinlifoobar) with some additional work (documentation, minor fixes, scalar test fixes).
## Rationale for this change
Add an additional useful regexp function to datafusion
## What changes are included in this PR?
Code, tests, documentation.
## Are these changes tested?
Yes.
## Are there any user-facing changes?
Docs updated to include the new udf.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Add regexp_count function [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #12970:
URL: https://github.com/apache/datafusion/pull/12970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Add regexp_count function [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #12970:
URL: https://github.com/apache/datafusion/pull/12970#issuecomment-2423173914
FYI @xinlifoobar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add regexp_count function [datafusion]
Posted by "Omega359 (via GitHub)" <gi...@apache.org>.
Omega359 commented on PR #12970:
URL: https://github.com/apache/datafusion/pull/12970#issuecomment-2417124662
Note this PR does not resolve the performance degradation seen in this function as compared to regexp_match or regexp_like. (see https://github.com/apache/datafusion/pull/12080#issuecomment-2316755718 for a benchmark) I believe that should be looked at in a followup ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Add regexp_count function [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #12970:
URL: https://github.com/apache/datafusion/pull/12970#issuecomment-2423178697
> Note this PR does not resolve the performance degradation seen in this function as compared to regexp_match or regexp_like. (see [#12080 (comment)](https://github.com/apache/datafusion/pull/12080#issuecomment-2316755718) for a benchmark) I believe that should be looked at in a followup ticket.
Filed https://github.com/apache/datafusion/issues/13011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org