You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:30:18 UTC
[GitHub] [incubator-dolphinscheduler] yh2388 opened a new pull request #4015: [Fix][api] Fix build parameter error of sqlserver when create.
yh2388 opened a new pull request #4015:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4015
Fix jdbcUrl splicing error of SQLServer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #4015: [Fix][api] Fix build parameter error of sqlserver when create.
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #4015:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4015#issuecomment-720908096
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4015&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4015&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4015&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4015&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4015&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4015&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4015&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje
ct/issues?id=apache-dolphinscheduler&pullRequest=4015&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4015&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4015&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4015&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60.png' alt='60.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=4015&metric=new_coverage&view=list) [60.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=4015&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=4015&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=4015&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yh2388 commented on pull request #4015: [Fix][api] Fix build parameter error of sqlserver when create.
Posted by GitBox <gi...@apache.org>.
yh2388 commented on pull request #4015:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4015#issuecomment-727557819
> Looking forward to your submission of a new pr to complete the changes required by @gabrywu
okay.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] gabrywu commented on a change in pull request #4015: [Fix][api] Fix build parameter error of sqlserver when create.
Posted by GitBox <gi...@apache.org>.
gabrywu commented on a change in pull request #4015:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4015#discussion_r517847579
##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/DataSourceService.java
##########
@@ -499,7 +499,13 @@ public String buildParameter(DbType type, String host,
String address = buildAddress(type, host, port, connectType);
Map<String, Object> parameterMap = new LinkedHashMap<String, Object>(6);
- String jdbcUrl = address + "/" + database;
+ String jdbcUrl;
+ if (DbType.SQLSERVER == type) {
+ jdbcUrl = address + ";databaseName=" + database;
+ } else {
+ jdbcUrl = address + "/" + database;
+ }
+
if (Constants.ORACLE.equals(type.name())) {
Review comment:
Do you mind removing the following constants? I think using '==' is better, after all, the 'type' variable is Enum
public static final String MYSQL = "MYSQL";
public static final String POSTGRESQL = "POSTGRESQL";
public static final String HIVE = "HIVE";
public static final String SPARK = "SPARK";
public static final String CLICKHOUSE = "CLICKHOUSE";
public static final String ORACLE = "ORACLE";
public static final String SQLSERVER = "SQLSERVER";
public static final String DB2 = "DB2";
public static final String PRESTO = "PRESTO";
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] CalvinKirs merged pull request #4015: [Fix][api] Fix build parameter error of sqlserver when create.
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #4015:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4015
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] qiaozhanwei commented on a change in pull request #4015: [Fix][api] Fix build parameter error of sqlserver when create.
Posted by GitBox <gi...@apache.org>.
qiaozhanwei commented on a change in pull request #4015:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4015#discussion_r521781677
##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/DataSourceService.java
##########
@@ -499,7 +499,13 @@ public String buildParameter(DbType type, String host,
String address = buildAddress(type, host, port, connectType);
Map<String, Object> parameterMap = new LinkedHashMap<String, Object>(6);
- String jdbcUrl = address + "/" + database;
+ String jdbcUrl;
+ if (DbType.SQLSERVER == type) {
+ jdbcUrl = address + ";databaseName=" + database;
+ } else {
+ jdbcUrl = address + "/" + database;
+ }
+
if (Constants.ORACLE.equals(type.name())) {
Review comment:
agree with @gabrywu idea . but this modify maybe involved not only DbType . suggest again submit a new PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org