You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/10 14:53:26 UTC

[GitHub] [maven] pzygielo commented on a diff in pull request #809: Consider inactive profiles for validation

pzygielo commented on code in PR #809:
URL: https://github.com/apache/maven/pull/809#discussion_r991376962


##########
maven-core/src/main/java/org/apache/maven/DefaultMaven.java:
##########
@@ -466,7 +468,9 @@ private void validatePrerequisitesForNonMavenPluginProjects( List<MavenProject>
         }
     }
 
-    private void validateActivatedProfiles( List<MavenProject> projects, List<String> activeProfileIds )
+    private void validateActivatedProfiles( List<MavenProject> projects,
+                                            List<String> activeProfileIds,
+                                            List<String> inactiveProfiles )

Review Comment:
   I followed the name of method used in the call. I agree that local naming style should be preserved here - will update that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org