You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "wenjin272 (via GitHub)" <gi...@apache.org> on 2026/05/06 03:31:52 UTC

[PR] [api][runtime][integration] Support Mem0 based Long-Term Memory on the Java side. [flink-agents]

wenjin272 opened a new pull request, #647:
URL: https://github.com/apache/flink-agents/pull/647

   <!--
   * Thank you very much for contributing to Flink Agents.
   * Please add the relevant components in the PR title. E.g., [api], [runtime], [java], [python], [hotfix], etc.
   -->
   
   <!-- Please link the PR to the relevant issue(s). Hotfix doesn't need this. -->
   Linked issue: #619 and #620
   
   ### Purpose of change
   
   1. Drop the `VectorStoreLongTermMemory` in java
   2. Refactor the vector store API to align with the Python side.
   3. Support Mem0 based Long-Term Memory on the Java side.
   
   ### Tests
   
   ut & e2e
   
   ### API
   
   <!-- Does this change touches any public APIs? -->
   
   ### Documentation
   
   <!-- Do not remove this section. Check the proper box only. -->
   
   - [ ] `doc-needed` <!-- Your PR changes impact docs -->
   - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-included` <!-- Your PR already contains the necessary documentation updates -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [api][runtime][integration] Support Mem0 based Long-Term Memory on the Java side. [flink-agents]

Posted by "wenjin272 (via GitHub)" <gi...@apache.org>.
wenjin272 merged PR #647:
URL: https://github.com/apache/flink-agents/pull/647


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [api][runtime][integration] Support Mem0 based Long-Term Memory on the Java side. [flink-agents]

Posted by "wenjin272 (via GitHub)" <gi...@apache.org>.
wenjin272 commented on PR #647:
URL: https://github.com/apache/flink-agents/pull/647#issuecomment-4384930741

   ### Code review
   
   Found 1 issue:
   
   1. `VectorStoreQuery.filters` is silently dropped in both directions of the Java↔Python bridge. `JavaResourceAdapter.fromPythonVectorStoreQuery` calls the 5-arg `VectorStoreQuery` constructor (whose Javadoc reads "no filters") and never reads the Python object's `filters` attribute. Symmetrically, `python_java_utils.from_java_vector_store_query` builds a Python `VectorStoreQuery` without calling `j_query.getFilters()`. Any query carrying metadata filters crossing the language boundary will silently lose its filter DSL — the resulting query then matches everything in the collection rather than the filtered subset.
   
   https://github.com/apache/flink-agents/blob/1ef6e629f17c1dd9404db1b939e15fad7ea4fa1c/runtime/src/main/java/org/apache/flink/agents/runtime/python/utils/JavaResourceAdapter.java#L99-L112
   
   https://github.com/apache/flink-agents/blob/1ef6e629f17c1dd9404db1b939e15fad7ea4fa1c/python/flink_agents/runtime/python_java_utils.py#L254-L263
   
   🤖 Generated with [Claude Code](https://claude.ai/code)
   
   <sub>- If this code review was useful, please react with 👍. Otherwise, react with 👎.</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org