You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Julian Hyde (Jira)" <ji...@apache.org> on 2019/10/24 23:23:00 UTC

[jira] [Updated] (CALCITE-3436) In CalciteConnectionConfigImpl, add "isSet" and "unset" methods

     [ https://issues.apache.org/jira/browse/CALCITE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Hyde updated CALCITE-3436:
---------------------------------
    Summary: In CalciteConnectionConfigImpl, add "isSet" and "unset" methods  (was: CalciteConnectionConfigImpl.set obliterates previous property values)

> In CalciteConnectionConfigImpl, add "isSet" and "unset" methods
> ---------------------------------------------------------------
>
>                 Key: CALCITE-3436
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3436
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Ryan Fu
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> The cause is that `new Properties(properties)` doesn't copy the previous value as, say, `new HashMap(map)` does.
>  
>  * Add a unit test in PlannerTest, that if you call set(x, 1) then set(y, 2) on a CalciteConnectionConfigImpl, the result contains x and y. 
>  * Consider potentially using `clone()` as Properties implements Cloneable



--
This message was sent by Atlassian Jira
(v8.3.4#803005)