You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Jeremy Daggett <no...@github.com> on 2014/09/10 20:31:05 UTC

[jclouds-labs-openstack] Backport JCLOUDS-630 to 1.8.x (#142)

Master: 007a3b7
JIRA: https://issues.apache.org/jira/browse/JCLOUDS-630
You can merge this Pull Request by running:

  git pull https://github.com/rackerlabs/jclouds-labs-openstack fix/jclouds-630-1.8.x

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-labs-openstack/pull/142

-- Commit Summary --

  * JCLOUDS-630: Map Payload ContentMetadata expires to Swift X-Delete-At header for object expiration.

-- File Changes --

    M openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/binders/SetPayload.java (14)
    M openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/blobstore/functions/ToBlobMetadata.java (6)
    D openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/blobstore/functions/ToSwiftObject.java (54)
    M openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/functions/ParseObjectFromResponse.java (17)
    M openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/functions/ParseObjectListFromResponse.java (6)
    M openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/features/ObjectApiLiveTest.java (27)
    M openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/features/ObjectApiMockTest.java (52)

-- Patch Links --

https://github.com/jclouds/jclouds-labs-openstack/pull/142.patch
https://github.com/jclouds/jclouds-labs-openstack/pull/142.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/142

Re: [jclouds-labs-openstack] Backport JCLOUDS-630 to 1.8.x (#142)

Posted by Andrew Phillips <no...@github.com>.
> +      Payload payload = newByteSourcePayload(ByteSource.wrap("swifty".getBytes()));
> +      payload.getContentMetadata().setExpires(expireAt);
> +
> +      for (String regionId : regions) {
> +         String etag = api.getObjectApiForRegionAndContainer(regionId, containerName)
> +               .put(objectName, payload);
> +         assertNotNull(etag);
> +
> +         SwiftObject object = api.getObjectApiForRegionAndContainer(regionId, containerName).get(objectName);
> +         assertEquals(object.getName(), objectName);
> +         checkObject(object);
> +         assertEquals(toStringAndClose(object.getPayload().openStream()), "swifty");
> +
> +         api.getObjectApiForRegionAndContainer(regionId, containerName).delete(objectName);
> +      }
> +   }

See comments about this test in #118

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/142/files#r17510682

Re: [jclouds-labs-openstack] Backport JCLOUDS-630 to 1.8.x (#142)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #427](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/427/) UNSTABLE
Looks like there's a problem with this pull request

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/142#issuecomment-55307159

Re: [jclouds-labs-openstack] Backport JCLOUDS-630 to 1.8.x (#142)

Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds-labs-openstack #1711](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1711/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/142#issuecomment-55162716

Re: [jclouds-labs-openstack] Backport JCLOUDS-630 to 1.8.x (#142)

Posted by Andrew Phillips <no...@github.com>.
> @@ -160,7 +163,8 @@ public void testCreate() throws Exception {
>        server.enqueue(addCommonHeaders(new MockResponse().setBody(stringFromResource("/access.json"))));
>        server.enqueue(addCommonHeaders(new MockResponse()
>              .setResponseCode(201)
> -            .addHeader("ETag", "d9f5eb4bba4e2f2f046e54611bc8196b")));
> +            .addHeader("ETag", "d9f5eb4bba4e2f2f046e54611bc8196b"))
> +            .addHeader("Expires", "1406243553"));

See comment in #118

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/142/files#r17510685

Re: [jclouds-labs-openstack] Backport JCLOUDS-630 to 1.8.x (#142)

Posted by Jeremy Daggett <no...@github.com>.
Reopened #142.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/142#event-164368147

Re: [jclouds-labs-openstack] Backport JCLOUDS-630 to 1.8.x (#142)

Posted by Jeremy Daggett <no...@github.com>.
Pushed to 1.8.x 756d686

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/142#issuecomment-55307796

Re: [jclouds-labs-openstack] Backport JCLOUDS-630 to 1.8.x (#142)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #426](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/426/) UNSTABLE
Looks like there's a problem with this pull request

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/142#issuecomment-55162783

Re: [jclouds-labs-openstack] Backport JCLOUDS-630 to 1.8.x (#142)

Posted by Jeremy Daggett <no...@github.com>.
Closed #142.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/142#event-164368128

Re: [jclouds-labs-openstack] Backport JCLOUDS-630 to 1.8.x (#142)

Posted by Jeremy Daggett <no...@github.com>.
Closed #142.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/142#event-164379227