You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2019/07/11 05:27:11 UTC
[GitHub] [phoenix] priyankporwal commented on a change in pull request #531:
PHOENIX-5385: GlobalIndexChecker coproc doesn't load on view indexes
priyankporwal commented on a change in pull request #531: PHOENIX-5385: GlobalIndexChecker coproc doesn't load on view indexes
URL: https://github.com/apache/phoenix/pull/531#discussion_r302368255
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java
##########
@@ -894,6 +897,7 @@ private void send(Iterator<TableRef> tableRefIterator) throws SQLException {
MultiRowMutationState multiRowMutationState;
Map<TableInfo, List<Mutation>> physicalTableMutationMap = Maps.newLinkedHashMap();
+ Map<TableInfo, TableRef> physicalLogicalMap = Maps.newLinkedHashMap();
Review comment:
Nit: Please rename this to logicalToPhysicalMap .. this one is easy to be read as 'physicalToLogicalMap' and being passed to filterIndexCheckerMutations() where logicalToPhysicalMap is expected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services