[jira] [Comment Edited] (FLINK-27886) Error way for skipping shade plugin in sub-modules

["Ran Tao (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-27886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545516#comment-17545516 ] 

Ran Tao edited comment on FLINK-27886 at 6/2/22 3:24 PM:
---------------------------------------------------------

[~gaoyunhaii], [~jark] Hi, gaoyun, jark, can u help me to review this issue?


was (Author: lemonjing):
[~gaoyunhaii][~jark] Hi, gaoyun, jark, can u help me to review this issue?

> Error way for skipping shade plugin in sub-modules
> --------------------------------------------------
>
>                 Key: FLINK-27886
>                 URL: https://issues.apache.org/jira/browse/FLINK-27886
>             Project: Flink
>          Issue Type: Improvement
>          Components: BuildSystem / Shaded
>    Affects Versions: 1.15.0, 1.13.6, 1.14.4
>            Reporter: Ran Tao
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: screenshot-1.png, screenshot-2.png
>
>
> Currently in some sub-modules, for example, flink-quickstart-java  flink-quickstart-scala, flink-walkthrough, we want to skip shade but use error way like this
> {code:java}
> <plugin>
> 				<groupId>org.apache.maven.plugins</groupId>
> 				<artifactId>maven-shade-plugin</artifactId>
> 				<executions>
> 					<execution>
> 						</phase>
> 					</execution>
> 				</executions>
> 			</plugin>
> {code}
> It just set none phase for itself, can't forbid the inherited parent shade.
>  !screenshot-1.png! 
>  !screenshot-2.png! 
> the correct way is 
> {code:java}
> <plugin>
> 				<groupId>org.apache.maven.plugins</groupId>
> 				<artifactId>maven-shade-plugin</artifactId>
> 				<executions>
> 					<execution>
> 						<id>shade-flink</id>
> 						<phase>none</phase>
> 					</execution>
> 				</executions>
> 			</plugin>
> {code}
> it can forbid parent shade-flink and also it's own shade. because there is no extra own shade executions.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)