[GitHub] [spark] zero323 commented on a change in pull request #34216: [SPARK-36942][PYTHON] Inline type hints for python/pyspark/sql/readwriter.py

[GitBox <gi...@apache.org>]

zero323 commented on a change in pull request #34216:
URL: https://github.com/apache/spark/pull/34216#discussion_r727965478



##########
File path: python/pyspark/sql/readwriter.py
##########
@@ -15,29 +15,52 @@
 # limitations under the License.
 #
 import sys
-
-from py4j.java_gateway import JavaClass
+from typing import (
+    overload,
+    Dict,
+    Iterable,
+    List,
+    Optional,
+    Tuple,
+    TYPE_CHECKING,
+    Union
+)
+
+from py4j.java_gateway import JavaClass, JavaObject
 
 from pyspark import RDD, since
-from pyspark.sql.column import _to_seq, _to_java_column
+from pyspark.sql.column import _to_seq, _to_java_column, Column  # type: ignore[attr-defined]

Review comment:
       This ignore shouldn't be necessary, once it is in sync with master, right?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org