You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Attila Szabo <as...@cloudera.com> on 2016/10/13 12:49:26 UTC
Re: Review Request 50566: Add validation check for --hive-import and
--incremental lastmodified
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50566/#review152487
-----------------------------------------------------------
Hi @Szabi,
It seems trunk has been diverged since the time you'd created the lates patch. Although your solution looks good, could you please provide an updated version of the patch file, which applies to the current trunk version?
Many thanks in advance!
- Attila Szabo
On July 28, 2016, 1:07 p.m., Szabolcs Vasas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50566/
> -----------------------------------------------------------
>
> (Updated July 28, 2016, 1:07 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2986
> https://issues.apache.org/jira/browse/SQOOP-2986
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Add validation check for --hive-import and --incremental lastmodified
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/tool/BaseSqoopTool.java fecdf43
> src/test/org/apache/sqoop/tool/ImportToolValidateOptionsTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/50566/diff/
>
>
> Testing
> -------
>
> New unit test cases are added, also tested manually by executing sqoop import command.
>
>
> Thanks,
>
> Szabolcs Vasas
>
>