You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "chovy-3012 (via GitHub)" <gi...@apache.org> on 2026/09/21 03:32:47 UTC
[PR] [Improvement][API&DAO&UI] Support field sorting on workflow definitio… [dolphinscheduler]
chovy-3012 opened a new pull request, #18658:
URL: https://github.com/apache/dolphinscheduler/pull/18658
<!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! -->
## Was this PR generated or assisted by AI?
<!--(Please answer YES or NO. If YES, please specify which parts were generated or assisted by AI)-->
NO
## Purpose of the pull request
Add field sorting by name / createTime / updateTime to
the workflow definition list. Allowing users to sort by name, createTime, or updateTime by clicking the corresponding column header.
<!--(For example: This pull request adds checkstyle plugin).-->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
```shell
./mvnw -pl dolphinscheduler-api -am test -Dtest='WorkflowDefinitionServiceTest,WorkflowDefinitionControllerTest' \
-Djacoco.skip=true -Denforcer.skip=true -Dsurefire.failIfNoSpecifiedTests=false -q
```
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
(or)
## Pull Request Notice
[Pull Request Notice](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
If your pull request contains incompatible change, you should also add it to `docs/docs/en/guide/upgrade/incompatible.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-18666] Support field sorting on workflow definition list [dolphinscheduler]
Posted by "chovy-3012 (via GitHub)" <gi...@apache.org>.
chovy-3012 commented on PR #18658:
URL: https://github.com/apache/dolphinscheduler/pull/18658#issuecomment-5944430755
Hi maintainers,
The `Mergeable: milestone-label-check` check is failing because none of the
current labels match the allowlist in `.github/workflows/mergeable.yml`
(`feature`/`bug`/`improvement`/`document`/`chore`/`DSIP`/`CI&CD`/`revert`).
Milestone (`3.5.0`) is already set — only the type label is missing.
Could a maintainer add the `improvement` label to match `[Improvement-18666]`?
The check re-runs on `labeled` and should pass right after. All code-level
checks are already green.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-18666] Support field sorting on workflow definition list [dolphinscheduler]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #18658:
URL: https://github.com/apache/dolphinscheduler/pull/18658#issuecomment-6050327127
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-18666] Support field sorting on workflow definition list [dolphinscheduler]
Posted by "chovy-3012 (via GitHub)" <gi...@apache.org>.
chovy-3012 commented on PR #18658:
URL: https://github.com/apache/dolphinscheduler/pull/18658#issuecomment-5882231960
> WorkflowDefinitionMapper.xml handles the field and direction fallbacks independently. Consequently, sortField=foo&sortOrder=asc produces update_time asc, id asc, whereas #18666 specifies update_time desc for unrecognized fields. Please apply the complete default ordering when sortField is invalid and cover this parameter combination.
Thanks. The field and direction were two independent <choose> blocks, so sortField=foo&sortOrder=asc fell back to update_time for the field but still honored asc for the direction, yielding update_time asc, id asc instead of the complete default.
Fixed by merging them into a single nested <choose>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-18666] Support field sorting on workflow definition list [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS merged PR #18658:
URL: https://github.com/apache/dolphinscheduler/pull/18658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][API&DAO&UI] Support field sorting on workflow definitio… [dolphinscheduler]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #18658:
URL: https://github.com/apache/dolphinscheduler/pull/18658#issuecomment-5755022581
Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-18666] Support field sorting on workflow definition list [dolphinscheduler]
Posted by "chovy-3012 (via GitHub)" <gi...@apache.org>.
chovy-3012 commented on PR #18658:
URL: https://github.com/apache/dolphinscheduler/pull/18658#issuecomment-5870540284
> Please follow the pull request notice.
Thanks for the pointer — I've aligned this PR with the Pull Request Notice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org