You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/07/20 19:26:27 UTC
[GitHub] [flink] MartijnVisser opened a new pull request #16546: [FLINK-23438] Bump httpclient from 4.5.3 and 4.5.9 to 4.5.13
MartijnVisser opened a new pull request #16546:
URL: https://github.com/apache/flink/pull/16546
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
* Flink is still using org.apache.httpcomponents.httpclient:4.5.3 and org.apache.httpcomponents.httpclient:4.5.9. Those versions are impacted by CVE-2020-13956 (though Flink is not impacted by it). The latest available version is 4.5.13
## Brief change log
- Updated httpclient dependencies from 4.5.3 and 4.5.9 to 4.5.13
- Updated NOTICE files to deal with new version number
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): yes
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): don't know
- Anything that affects deployment or recovery: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser closed pull request #16546: [FLINK-23438] Bump httpclient from 4.5.3 and 4.5.9 to 4.5.13
Posted by GitBox <gi...@apache.org>.
MartijnVisser closed pull request #16546:
URL: https://github.com/apache/flink/pull/16546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a change in pull request #16546: [FLINK-23438] Bump httpclient from 4.5.3 and 4.5.9 to 4.5.13
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on a change in pull request #16546:
URL: https://github.com/apache/flink/pull/16546#discussion_r674109292
##########
File path: flink-filesystems/flink-s3-fs-hadoop/src/main/resources/META-INF/NOTICE
##########
@@ -30,7 +30,7 @@ This project bundles the following dependencies under the Apache Software Licens
- org.apache.hadoop:hadoop-common:3.1.0
- org.apache.htrace:htrace-core4:4.1.0-incubating
- org.apache.httpcomponents:httpcore:4.4.6
Review comment:
I didn't want to create a PR with multiple dependency updates. If you prefer, I can definitely include it. Let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16546: [FLINK-23438] Bump httpclient from 4.5.3 and 4.5.9 to 4.5.13
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16546:
URL: https://github.com/apache/flink/pull/16546#issuecomment-883640566
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 227ebe5613b9e2a41a811b69bf3578807d289b01 (Tue Jul 20 19:30:13 UTC 2021)
**Warnings:**
* **5 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16546: [FLINK-23438] Bump httpclient from 4.5.3 and 4.5.9 to 4.5.13
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16546:
URL: https://github.com/apache/flink/pull/16546#issuecomment-883647295
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "227ebe5613b9e2a41a811b69bf3578807d289b01",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20748",
"triggerID" : "227ebe5613b9e2a41a811b69bf3578807d289b01",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 227ebe5613b9e2a41a811b69bf3578807d289b01 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20748)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #16546: [FLINK-23438] Bump httpclient from 4.5.3 and 4.5.9 to 4.5.13
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #16546:
URL: https://github.com/apache/flink/pull/16546#discussion_r673748129
##########
File path: flink-filesystems/flink-s3-fs-presto/pom.xml
##########
@@ -219,7 +219,7 @@ under the License.
<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
- <version>4.5.9</version>
Review comment:
this entry could not be removed since it is subsumed by the root pom entry
##########
File path: flink-end-to-end-tests/flink-glue-schema-registry-test/pom.xml
##########
@@ -33,7 +33,7 @@ under the License.
<packaging>jar</packaging>
<properties>
- <httpclient.version>4.5.9</httpclient.version>
+ <httpclient.version>4.5.13</httpclient.version>
Review comment:
Are we not able to remove this property and the usages in this file?
##########
File path: flink-connectors/flink-connector-kinesis/pom.xml
##########
@@ -258,7 +258,7 @@ under the License.
<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
- <version>4.5.9</version>
+ <version>4.5.13</version>
Review comment:
same comment as for the filesystems
##########
File path: flink-filesystems/flink-s3-fs-hadoop/pom.xml
##########
@@ -46,7 +46,7 @@ under the License.
<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
- <version>4.5.9</version>
+ <version>4.5.13</version>
Review comment:
same comment as for flink-s3-fs-presto
##########
File path: flink-filesystems/flink-s3-fs-hadoop/src/main/resources/META-INF/NOTICE
##########
@@ -30,7 +30,7 @@ This project bundles the following dependencies under the Apache Software Licens
- org.apache.hadoop:hadoop-common:3.1.0
- org.apache.htrace:htrace-core4:4.1.0-incubating
- org.apache.httpcomponents:httpcore:4.4.6
Review comment:
why are we not bumping httpcore as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16546: [FLINK-23438] Bump httpclient from 4.5.3 and 4.5.9 to 4.5.13
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16546:
URL: https://github.com/apache/flink/pull/16546#issuecomment-883647295
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "227ebe5613b9e2a41a811b69bf3578807d289b01",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20748",
"triggerID" : "227ebe5613b9e2a41a811b69bf3578807d289b01",
"triggerType" : "PUSH"
}, {
"hash" : "e8852f59b1c81da91e5fddb8ee6fbe34069a448a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20871",
"triggerID" : "e8852f59b1c81da91e5fddb8ee6fbe34069a448a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e8852f59b1c81da91e5fddb8ee6fbe34069a448a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20871)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16546: [FLINK-23438] Bump httpclient from 4.5.3 and 4.5.9 to 4.5.13
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16546:
URL: https://github.com/apache/flink/pull/16546#issuecomment-883647295
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "227ebe5613b9e2a41a811b69bf3578807d289b01",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "227ebe5613b9e2a41a811b69bf3578807d289b01",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 227ebe5613b9e2a41a811b69bf3578807d289b01 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16546: [FLINK-23438] Bump httpclient from 4.5.3 and 4.5.9 to 4.5.13
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16546:
URL: https://github.com/apache/flink/pull/16546#issuecomment-883647295
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "227ebe5613b9e2a41a811b69bf3578807d289b01",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20748",
"triggerID" : "227ebe5613b9e2a41a811b69bf3578807d289b01",
"triggerType" : "PUSH"
}, {
"hash" : "e8852f59b1c81da91e5fddb8ee6fbe34069a448a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e8852f59b1c81da91e5fddb8ee6fbe34069a448a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 227ebe5613b9e2a41a811b69bf3578807d289b01 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20748)
* e8852f59b1c81da91e5fddb8ee6fbe34069a448a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a change in pull request #16546: [FLINK-23438] Bump httpclient from 4.5.3 and 4.5.9 to 4.5.13
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on a change in pull request #16546:
URL: https://github.com/apache/flink/pull/16546#discussion_r674109292
##########
File path: flink-filesystems/flink-s3-fs-hadoop/src/main/resources/META-INF/NOTICE
##########
@@ -30,7 +30,7 @@ This project bundles the following dependencies under the Apache Software Licens
- org.apache.hadoop:hadoop-common:3.1.0
- org.apache.htrace:htrace-core4:4.1.0-incubating
- org.apache.httpcomponents:httpcore:4.4.6
Review comment:
I didn't want to create a PR with multiple dependencies. If you prefer, I can definitely include it. Let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #16546: [FLINK-23438] Bump httpclient from 4.5.3 and 4.5.9 to 4.5.13
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #16546:
URL: https://github.com/apache/flink/pull/16546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #16546: [FLINK-23438] Bump httpclient from 4.5.3 and 4.5.9 to 4.5.13
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #16546:
URL: https://github.com/apache/flink/pull/16546#discussion_r674543223
##########
File path: flink-filesystems/flink-s3-fs-hadoop/src/main/resources/META-INF/NOTICE
##########
@@ -30,7 +30,7 @@ This project bundles the following dependencies under the Apache Software Licens
- org.apache.hadoop:hadoop-common:3.1.0
- org.apache.htrace:htrace-core4:4.1.0-incubating
- org.apache.httpcomponents:httpcore:4.4.6
Review comment:
In practice it is part of httpclient so I would prefer to bump them at once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16546: [FLINK-23438] Bump httpclient from 4.5.3 and 4.5.9 to 4.5.13
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16546:
URL: https://github.com/apache/flink/pull/16546#issuecomment-883647295
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "227ebe5613b9e2a41a811b69bf3578807d289b01",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20748",
"triggerID" : "227ebe5613b9e2a41a811b69bf3578807d289b01",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 227ebe5613b9e2a41a811b69bf3578807d289b01 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20748)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16546: [FLINK-23438] Bump httpclient from 4.5.3 and 4.5.9 to 4.5.13
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16546:
URL: https://github.com/apache/flink/pull/16546#issuecomment-883647295
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "227ebe5613b9e2a41a811b69bf3578807d289b01",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20748",
"triggerID" : "227ebe5613b9e2a41a811b69bf3578807d289b01",
"triggerType" : "PUSH"
}, {
"hash" : "e8852f59b1c81da91e5fddb8ee6fbe34069a448a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20871",
"triggerID" : "e8852f59b1c81da91e5fddb8ee6fbe34069a448a",
"triggerType" : "PUSH"
}, {
"hash" : "201441d702ca476f2703422e7e736f83a4fe2369",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20947",
"triggerID" : "201441d702ca476f2703422e7e736f83a4fe2369",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 201441d702ca476f2703422e7e736f83a4fe2369 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20947)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16546: [FLINK-23438] Bump httpclient from 4.5.3 and 4.5.9 to 4.5.13
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16546:
URL: https://github.com/apache/flink/pull/16546#issuecomment-883647295
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "227ebe5613b9e2a41a811b69bf3578807d289b01",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20748",
"triggerID" : "227ebe5613b9e2a41a811b69bf3578807d289b01",
"triggerType" : "PUSH"
}, {
"hash" : "e8852f59b1c81da91e5fddb8ee6fbe34069a448a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20871",
"triggerID" : "e8852f59b1c81da91e5fddb8ee6fbe34069a448a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 227ebe5613b9e2a41a811b69bf3578807d289b01 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20748)
* e8852f59b1c81da91e5fddb8ee6fbe34069a448a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20871)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16546: [FLINK-23438] Bump httpclient from 4.5.3 and 4.5.9 to 4.5.13
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16546:
URL: https://github.com/apache/flink/pull/16546#issuecomment-883647295
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "227ebe5613b9e2a41a811b69bf3578807d289b01",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20748",
"triggerID" : "227ebe5613b9e2a41a811b69bf3578807d289b01",
"triggerType" : "PUSH"
}, {
"hash" : "e8852f59b1c81da91e5fddb8ee6fbe34069a448a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20871",
"triggerID" : "e8852f59b1c81da91e5fddb8ee6fbe34069a448a",
"triggerType" : "PUSH"
}, {
"hash" : "201441d702ca476f2703422e7e736f83a4fe2369",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20947",
"triggerID" : "201441d702ca476f2703422e7e736f83a4fe2369",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e8852f59b1c81da91e5fddb8ee6fbe34069a448a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20871)
* 201441d702ca476f2703422e7e736f83a4fe2369 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20947)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16546: [FLINK-23438] Bump httpclient from 4.5.3 and 4.5.9 to 4.5.13
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16546:
URL: https://github.com/apache/flink/pull/16546#issuecomment-883640566
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 201441d702ca476f2703422e7e736f83a4fe2369 (Sat Aug 28 12:22:54 UTC 2021)
**Warnings:**
* **5 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16546: [FLINK-23438] Bump httpclient from 4.5.3 and 4.5.9 to 4.5.13
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16546:
URL: https://github.com/apache/flink/pull/16546#issuecomment-883647295
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "227ebe5613b9e2a41a811b69bf3578807d289b01",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20748",
"triggerID" : "227ebe5613b9e2a41a811b69bf3578807d289b01",
"triggerType" : "PUSH"
}, {
"hash" : "e8852f59b1c81da91e5fddb8ee6fbe34069a448a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20871",
"triggerID" : "e8852f59b1c81da91e5fddb8ee6fbe34069a448a",
"triggerType" : "PUSH"
}, {
"hash" : "201441d702ca476f2703422e7e736f83a4fe2369",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "201441d702ca476f2703422e7e736f83a4fe2369",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e8852f59b1c81da91e5fddb8ee6fbe34069a448a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20871)
* 201441d702ca476f2703422e7e736f83a4fe2369 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #16546: [FLINK-23438] Bump httpclient from 4.5.3 and 4.5.9 to 4.5.13
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #16546:
URL: https://github.com/apache/flink/pull/16546#issuecomment-884307460
@zentol I'm testing the other review comments now, I'll get back to you when tests have completed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #16546: [FLINK-23438] Bump httpclient from 4.5.3 and 4.5.9 to 4.5.13
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #16546:
URL: https://github.com/apache/flink/pull/16546#discussion_r675357493
##########
File path: flink-connectors/flink-connector-kinesis/pom.xml
##########
@@ -258,7 +258,7 @@ under the License.
<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
- <version>4.5.9</version>
+ <version>4.5.13</version>
Review comment:
Why is this entry still there? Was there a problem after removing it?
##########
File path: flink-connectors/flink-connector-kinesis/pom.xml
##########
@@ -234,17 +232,6 @@ under the License.
<version>${aws.sdkv2.version}</version>
</dependency>
- <dependency>
- <groupId>org.apache.httpcomponents</groupId>
- <artifactId>httpclient</artifactId>
Review comment:
These should actually stay. This ensures that if a _user_ bundles this this connector in the jar they still get this version of the dependency. In that scenario what we define in the dependency management is completely ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #16546: [FLINK-23438] Bump httpclient from 4.5.3 and 4.5.9 to 4.5.13
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #16546:
URL: https://github.com/apache/flink/pull/16546#discussion_r673748129
##########
File path: flink-filesystems/flink-s3-fs-presto/pom.xml
##########
@@ -219,7 +219,7 @@ under the License.
<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
- <version>4.5.9</version>
Review comment:
this entry could maybe be removed since it is subsumed by the root pom entry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org