You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/09/28 08:31:44 UTC

[GitHub] flink pull request #4741: [hotfix] [REST] Add testbase for requests / allow ...

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/4741

    [hotfix] [REST] Add testbase for requests / allow exceptions

    ## What is the purpose of the change
    
    Add a test base for marshalling request bodies.
    
    ## Brief change log
    
    * add test base
    * allow throwing exceptions when creating the test instance
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    @tillrohrmann 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 7725

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4741.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4741
    
----
commit de91c3b716fe223a1288b45b454903ed89c67c8b
Author: zentol <ch...@apache.org>
Date:   2017-09-28T08:25:58Z

    [hotfix] [REST] Add testbase for requests / allow exceptions

----


---

[GitHub] flink issue #4741: [hotfix] [REST] Add testbase for requests / allow excepti...

Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/4741
  
    +1, LGTM


---

[GitHub] flink issue #4741: [FLINK-7725] [REST] Add testbase for requests / allow exc...

Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4741
  
    Ill add the JIRA ID while merging, along with removing some unused imports that caused checkstyle to fail.


---

[GitHub] flink pull request #4741: [FLINK-7725] [REST] Add testbase for requests / al...

Posted by zentol <gi...@git.apache.org>.
Github user zentol closed the pull request at:

    https://github.com/apache/flink/pull/4741


---