You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/11/19 10:56:02 UTC

[GitHub] [airflow] potiuk commented on issue #6576: [AIRFLOW-5922] Add option to specify the mysql client library used in MySqlHook

potiuk commented on issue #6576: [AIRFLOW-5922] Add option to specify the mysql client library used in MySqlHook
URL: https://github.com/apache/airflow/pull/6576#issuecomment-555452928
 
 
   @feluelle. Exactly ! I think the only thing missing is to restore the connection after the tests. It should be a good practice that tests should not change the state so it would be great if the set_client method is a context manager that will set the connection first and restore them when leaving the context.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services