[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2881: FINERACT-1856: Fix to update datatable entry is failing after column added lately

[GitBox <gi...@apache.org>]

josehernandezfintecheandomx commented on code in PR #2881:
URL: https://github.com/apache/fineract/pull/2881#discussion_r1071246923


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java:
##########
@@ -430,7 +430,8 @@ public CommandProcessingResult updateClient(final Long clientId, final JsonComma
             }
 
             final ExternalId externalId = externalIdFactory.createFromCommand(command, ClientApiConstants.externalIdParamName);
-            if (command.isChangeInStringParameterNamed(ClientApiConstants.externalIdParamName, externalId.getValue())) {
+            if (command.isChangeInStringParameterNamed(ClientApiConstants.externalIdParamName,
+                    clientForUpdate.getExternalId().getValue())) {

Review Comment:
   This is an issue in the client update, In the comparation there is not difference and then If you change the external Id value It is not updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org