You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/11/27 12:12:35 UTC
[GitHub] [dolphinscheduler] linyanbin666 opened a new pull request #7026: [Improvement-6725][API+UI]: Support to change the owner of project/datasource/resource/udfFunc
linyanbin666 opened a new pull request #7026:
URL: https://github.com/apache/dolphinscheduler/pull/7026
## Purpose of the pull request
close #6725
## Brief change log
- Add a transfer button in user management page
- Support to change the owner of project/datasource/resource/udfFunc
## Verify this pull request
Manually verified the change by testing locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] removed a comment on pull request #7026: [Improvement-6725][API+UI]: Support to change the owner of project/datasource/resource/udfFunc
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #7026:
URL: https://github.com/apache/dolphinscheduler/pull/7026#issuecomment-980566105
SonarCloud Quality Gate failed. 
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=CODE_SMELL) [11 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7026&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7026&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7026&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7026&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter edited a comment on pull request #7026: [Improvement-6725][API+UI]: Support to change the owner of project/datasource/resource/udfFunc
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #7026:
URL: https://github.com/apache/dolphinscheduler/pull/7026#issuecomment-980561237
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/7026?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7026](https://codecov.io/gh/apache/dolphinscheduler/pull/7026?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (db8e63d) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/ed9fca6c976761abcf4cef2656b61516fd976ad0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ed9fca6) will **decrease** coverage by `0.00%`.
> The diff coverage is `33.33%`.
[](https://codecov.io/gh/apache/dolphinscheduler/pull/7026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## dev #7026 +/- ##
============================================
- Coverage 40.30% 40.29% -0.01%
- Complexity 3655 3669 +14
============================================
Files 653 656 +3
Lines 26917 27079 +162
Branches 3005 3019 +14
============================================
+ Hits 10848 10912 +64
- Misses 15044 15136 +92
- Partials 1025 1031 +6
```
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/7026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...lphinscheduler/api/controller/UsersController.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvVXNlcnNDb250cm9sbGVyLmphdmE=) | `53.84% <0.00%> (-4.49%)` | :arrow_down: |
| [...phinscheduler/api/exceptions/ServiceException.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2V4Y2VwdGlvbnMvU2VydmljZUV4Y2VwdGlvbi5qYXZh) | `61.11% <0.00%> (-12.23%)` | :arrow_down: |
| [...heduler/api/service/impl/ResourcesServiceImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9SZXNvdXJjZXNTZXJ2aWNlSW1wbC5qYXZh) | `48.82% <0.00%> (-3.62%)` | :arrow_down: |
| [...scheduler/api/service/impl/UdfFuncServiceImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9VZGZGdW5jU2VydmljZUltcGwuamF2YQ==) | `66.19% <0.00%> (-19.26%)` | :arrow_down: |
| [...ache/dolphinscheduler/api/utils/ResourceUtils.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3V0aWxzL1Jlc291cmNlVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...rg/apache/dolphinscheduler/dao/entity/UdfFunc.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9VZGZGdW5jLmphdmE=) | `79.24% <ø> (ø)` | |
| [...inscheduler/api/service/impl/UsersServiceImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9Vc2Vyc1NlcnZpY2VJbXBsLmphdmE=) | `76.90% <47.82%> (+2.13%)` | :arrow_up: |
| [...eduler/api/service/impl/DataSourceServiceImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9EYXRhU291cmNlU2VydmljZUltcGwuamF2YQ==) | `53.40% <94.73%> (+4.56%)` | :arrow_up: |
| [...scheduler/api/service/impl/ProjectServiceImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9Qcm9qZWN0U2VydmljZUltcGwuamF2YQ==) | `76.00% <94.73%> (+1.96%)` | :arrow_up: |
| [.../org/apache/dolphinscheduler/api/enums/Status.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2VudW1zL1N0YXR1cy5qYXZh) | `100.00% <100.00%> (ø)` | |
| ... and [4 more](https://codecov.io/gh/apache/dolphinscheduler/pull/7026/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/7026?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/7026?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ed9fca6...db8e63d](https://codecov.io/gh/apache/dolphinscheduler/pull/7026?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] songjianet commented on pull request #7026: [Improvement-6725][API+UI]: Support to change the owner of project/datasource/resource/udfFunc
Posted by GitBox <gi...@apache.org>.
songjianet commented on pull request #7026:
URL: https://github.com/apache/dolphinscheduler/pull/7026#issuecomment-1055247852
Thank you for your contribution, but it is currently in the switching period between the new and the old UI, and this function will not be implemented in the old UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] removed a comment on pull request #7026: [Improvement-6725][API+UI]: Support to change the owner of project/datasource/resource/udfFunc
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #7026:
URL: https://github.com/apache/dolphinscheduler/pull/7026#issuecomment-985998959
SonarCloud Quality Gate failed. 
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=CODE_SMELL) [10 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7026&metric=new_coverage&view=list) [32.2% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7026&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7026&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7026&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] songjianet closed pull request #7026: [Improvement-6725][API+UI]: Support to change the owner of project/datasource/resource/udfFunc
Posted by GitBox <gi...@apache.org>.
songjianet closed pull request #7026:
URL: https://github.com/apache/dolphinscheduler/pull/7026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] linyanbin666 commented on a change in pull request #7026: [Improvement-6725][API+UI]: Support to change the owner of project/datasource/resource/udfFunc
Posted by GitBox <gi...@apache.org>.
linyanbin666 commented on a change in pull request #7026:
URL: https://github.com/apache/dolphinscheduler/pull/7026#discussion_r775112166
##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ResourcesServiceImpl.java
##########
@@ -1356,4 +1363,108 @@ void listAllChildren(int resourceId,List<Integer> childList) {
return CollectionUtils.isEmpty(resIds) ? new ArrayList<>() : resourcesMapper.queryResourceListById(resIds);
}
+ /**
+ * query all resource component list created by user
+ *
+ * @param userId user id
+ * @return resource component list
+ */
+ @Override
+ public List<ResourceComponent> queryCreatedByUser(int userId) {
+ List<Resource> resourceList = resourcesMapper.queryResourceList(null, userId, -1);
+ if (CollectionUtils.isEmpty(resourceList)) {
+ return Collections.emptyList();
+ }
+ Visitor visitor = new ResourceTreeVisitor(resourceList);
+ return visitor.visit().getChildren();
+ }
+
+ /**
+ * transfer resource list owned by the user
+ *
+ * @param transferredUserId transferred user id
+ * @param receivedUserId received user id
+ * @param transferredIds transferred ids
+ * @return transfer result code
+ */
+ @Transactional(rollbackFor = Exception.class)
+ @Override
+ public Map<String, Object> transferOwnedData(int transferredUserId, int receivedUserId, List<Integer> transferredIds) {
+ Map<String, Object> result = new HashMap<>();
+
+ List<Resource> resources = resourcesMapper.selectList(Wrappers.<Resource>lambdaQuery()
+ .eq(Resource::getUserId, transferredUserId)
+ .in(Resource::getId, transferredIds)
+ );
+ Set<Integer> realResourceIds = resources.stream().map(Resource::getId).collect(Collectors.toSet());
+ // update resource owner
+ int updatedResourceNum = resourcesMapper.update(null, Wrappers.<Resource>lambdaUpdate()
+ .set(Resource::getUserId, receivedUserId)
+ .set(Resource::getUpdateTime, new Date())
+ .in(Resource::getId, realResourceIds)
+ );
+ if (updatedResourceNum != realResourceIds.size()) {
+ putMsg(result, Status.TRANSFER_RESOURCE_ERROR);
+ return result;
+ }
+ // delete project user relation if exist
+ resourceUserMapper.delete(Wrappers.<ResourcesUser>lambdaQuery()
+ .eq(ResourcesUser::getUserId, receivedUserId)
+ .in(ResourcesUser::getResourcesId, realResourceIds)
+ );
+
+ // copy resource file
+ copyResourceFiles(resources, transferredUserId, receivedUserId);
+
+ putMsg(result, Status.SUCCESS);
+ return result;
+ }
+
+ /**
+ * return the resource type
+ *
+ * @return transfer data type
+ */
+ @Override
+ public TransferDataType transferDataType() {
+ return TransferDataType.RESOURCE;
+ }
+
+ /**
+ * copy resource files
+ *
+ * @param resourceList resource list
+ * @param transferredUserId transferred user id
+ * @param receivedUserId received user id
+ */
+ private void copyResourceFiles(List<Resource> resourceList, int transferredUserId, int receivedUserId) {
+ if (CollectionUtils.isEmpty(resourceList)) {
+ return;
+ }
+ Map<Integer, User> userById = userMapper.selectByIds(Lists.newArrayList(transferredUserId, receivedUserId))
+ .stream().collect(Collectors.toMap(User::getId, Function.identity()));
+ if (!userById.containsKey(transferredUserId)) {
+ throw new ServiceException(Status.USER_NOT_EXIST, transferredUserId);
+ }
+ if (!userById.containsKey(receivedUserId)) {
+ throw new ServiceException(Status.USER_NOT_EXIST, receivedUserId);
+ }
+ Map<Integer, String> tenantCodeById = tenantMapper.selectBatchIds(userById.values().stream().map(User::getTenantId).collect(Collectors.toSet())).stream()
+ .collect(Collectors.toMap(Tenant::getId, Tenant::getTenantCode));
+ String transferredUserTenantCode = tenantCodeById.get(userById.get(transferredUserId).getTenantId());
+ String receivedUserTenantCode = tenantCodeById.get(userById.get(receivedUserId).getTenantId());
+ if (StringUtils.isBlank(transferredUserTenantCode) || StringUtils.isBlank(receivedUserTenantCode) ||
+ Objects.equals(transferredUserTenantCode, receivedUserTenantCode)) {
+ return;
+ }
+ try {
+ ResourceUtils.copyResourceFiles(resourceList, HadoopUtils.getHdfsResDir(transferredUserTenantCode),
Review comment:
This method already exists before this pr. Because it's needed here, I pulled it into a new class. Maybe we can discuss this in another issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #7026: [Improvement-6725][API+UI]: Support to change the owner of project/datasource/resource/udfFunc
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #7026:
URL: https://github.com/apache/dolphinscheduler/pull/7026#issuecomment-998699399
SonarCloud Quality Gate failed. 
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=CODE_SMELL) [10 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7026&metric=new_coverage&view=list) [32.2% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7026&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7026&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7026&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #7026: [Improvement-6725][API+UI]: Support to change the owner of project/datasource/resource/udfFunc
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #7026:
URL: https://github.com/apache/dolphinscheduler/pull/7026#issuecomment-985987867
SonarCloud Quality Gate failed. 
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=CODE_SMELL) [11 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7026&metric=new_coverage&view=list) [32.2% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7026&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7026&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7026&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #7026: [Improvement-6725][API+UI]: Support to change the owner of project/datasource/resource/udfFunc
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #7026:
URL: https://github.com/apache/dolphinscheduler/pull/7026#issuecomment-980566105
SonarCloud Quality Gate failed. 
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=CODE_SMELL) [11 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7026&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7026&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7026&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7026&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] calvinjiang commented on a change in pull request #7026: [Improvement-6725][API+UI]: Support to change the owner of project/datasource/resource/udfFunc
Posted by GitBox <gi...@apache.org>.
calvinjiang commented on a change in pull request #7026:
URL: https://github.com/apache/dolphinscheduler/pull/7026#discussion_r773960320
##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/DataSourceServiceImpl.java
##########
@@ -443,4 +447,62 @@ private String getHiddenPassword() {
return result;
}
+ /**
+ * query datasource list created by user
+ *
+ * @param userId user id
+ * @return datasource list
+ */
+ @Override
+ public List<DataSource> queryCreatedByUser(int userId) {
+ return dataSourceMapper.selectList(Wrappers.<DataSource>lambdaQuery().eq(DataSource::getUserId, userId));
+ }
+
+ /**
+ * transfer datasource list owned by the user
+ *
+ * @param transferredUserId transferred user id
+ * @param receivedUserId received user id
+ * @param transferredIds transferred ids
+ * @return transfer result code
+ */
+ @Override
+ public Map<String, Object> transferOwnedData(int transferredUserId, int receivedUserId, List<Integer> transferredIds) {
+ Map<String, Object> result = new HashMap<>();
+
+ List<DataSource> dataSources = dataSourceMapper.selectList(Wrappers.<DataSource>lambdaQuery()
+ .eq(DataSource::getUserId, transferredUserId)
+ .in(DataSource::getId, transferredIds)
+ );
+ Set<Integer> realDataSourceIds = dataSources.stream().map(DataSource::getId).collect(Collectors.toSet());
+ // update datasource owner
+ int updatedDatasourceNum = dataSourceMapper.update(null, Wrappers.<DataSource>lambdaUpdate()
Review comment:
As if this updating action could be combined with 'dataSourceMapper.selectList'. Seems like it below:
int updatedDatasourceNum = dataSourceMapper.update(null, Wrappers.<DataSource>lambdaUpdate()
.set(DataSource::getUserId, receivedUserId)
.set(DataSource::getUpdateTime, new Date())
.in(DataSource::getId, realDataSourceIds)
.eq(DataSource::getUserId, transferredUserId);
##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ResourcesServiceImpl.java
##########
@@ -1356,4 +1363,108 @@ void listAllChildren(int resourceId,List<Integer> childList) {
return CollectionUtils.isEmpty(resIds) ? new ArrayList<>() : resourcesMapper.queryResourceListById(resIds);
}
+ /**
+ * query all resource component list created by user
+ *
+ * @param userId user id
+ * @return resource component list
+ */
+ @Override
+ public List<ResourceComponent> queryCreatedByUser(int userId) {
+ List<Resource> resourceList = resourcesMapper.queryResourceList(null, userId, -1);
+ if (CollectionUtils.isEmpty(resourceList)) {
+ return Collections.emptyList();
+ }
+ Visitor visitor = new ResourceTreeVisitor(resourceList);
+ return visitor.visit().getChildren();
+ }
+
+ /**
+ * transfer resource list owned by the user
+ *
+ * @param transferredUserId transferred user id
+ * @param receivedUserId received user id
+ * @param transferredIds transferred ids
+ * @return transfer result code
+ */
+ @Transactional(rollbackFor = Exception.class)
+ @Override
+ public Map<String, Object> transferOwnedData(int transferredUserId, int receivedUserId, List<Integer> transferredIds) {
+ Map<String, Object> result = new HashMap<>();
+
+ List<Resource> resources = resourcesMapper.selectList(Wrappers.<Resource>lambdaQuery()
+ .eq(Resource::getUserId, transferredUserId)
+ .in(Resource::getId, transferredIds)
+ );
+ Set<Integer> realResourceIds = resources.stream().map(Resource::getId).collect(Collectors.toSet());
+ // update resource owner
+ int updatedResourceNum = resourcesMapper.update(null, Wrappers.<Resource>lambdaUpdate()
+ .set(Resource::getUserId, receivedUserId)
+ .set(Resource::getUpdateTime, new Date())
+ .in(Resource::getId, realResourceIds)
+ );
+ if (updatedResourceNum != realResourceIds.size()) {
+ putMsg(result, Status.TRANSFER_RESOURCE_ERROR);
+ return result;
+ }
+ // delete project user relation if exist
+ resourceUserMapper.delete(Wrappers.<ResourcesUser>lambdaQuery()
+ .eq(ResourcesUser::getUserId, receivedUserId)
+ .in(ResourcesUser::getResourcesId, realResourceIds)
+ );
+
+ // copy resource file
+ copyResourceFiles(resources, transferredUserId, receivedUserId);
+
+ putMsg(result, Status.SUCCESS);
+ return result;
+ }
+
+ /**
+ * return the resource type
+ *
+ * @return transfer data type
+ */
+ @Override
+ public TransferDataType transferDataType() {
+ return TransferDataType.RESOURCE;
+ }
+
+ /**
+ * copy resource files
+ *
+ * @param resourceList resource list
+ * @param transferredUserId transferred user id
+ * @param receivedUserId received user id
+ */
+ private void copyResourceFiles(List<Resource> resourceList, int transferredUserId, int receivedUserId) {
+ if (CollectionUtils.isEmpty(resourceList)) {
+ return;
+ }
+ Map<Integer, User> userById = userMapper.selectByIds(Lists.newArrayList(transferredUserId, receivedUserId))
+ .stream().collect(Collectors.toMap(User::getId, Function.identity()));
+ if (!userById.containsKey(transferredUserId)) {
+ throw new ServiceException(Status.USER_NOT_EXIST, transferredUserId);
+ }
+ if (!userById.containsKey(receivedUserId)) {
+ throw new ServiceException(Status.USER_NOT_EXIST, receivedUserId);
+ }
+ Map<Integer, String> tenantCodeById = tenantMapper.selectBatchIds(userById.values().stream().map(User::getTenantId).collect(Collectors.toSet())).stream()
+ .collect(Collectors.toMap(Tenant::getId, Tenant::getTenantCode));
+ String transferredUserTenantCode = tenantCodeById.get(userById.get(transferredUserId).getTenantId());
+ String receivedUserTenantCode = tenantCodeById.get(userById.get(receivedUserId).getTenantId());
+ if (StringUtils.isBlank(transferredUserTenantCode) || StringUtils.isBlank(receivedUserTenantCode) ||
+ Objects.equals(transferredUserTenantCode, receivedUserTenantCode)) {
+ return;
+ }
+ try {
+ ResourceUtils.copyResourceFiles(resourceList, HadoopUtils.getHdfsResDir(transferredUserTenantCode),
Review comment:
I'm not sure if there is an issue with overriding file when copying the same name file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] linyanbin666 commented on a change in pull request #7026: [Improvement-6725][API+UI]: Support to change the owner of project/datasource/resource/udfFunc
Posted by GitBox <gi...@apache.org>.
linyanbin666 commented on a change in pull request #7026:
URL: https://github.com/apache/dolphinscheduler/pull/7026#discussion_r775111480
##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/DataSourceServiceImpl.java
##########
@@ -443,4 +447,62 @@ private String getHiddenPassword() {
return result;
}
+ /**
+ * query datasource list created by user
+ *
+ * @param userId user id
+ * @return datasource list
+ */
+ @Override
+ public List<DataSource> queryCreatedByUser(int userId) {
+ return dataSourceMapper.selectList(Wrappers.<DataSource>lambdaQuery().eq(DataSource::getUserId, userId));
+ }
+
+ /**
+ * transfer datasource list owned by the user
+ *
+ * @param transferredUserId transferred user id
+ * @param receivedUserId received user id
+ * @param transferredIds transferred ids
+ * @return transfer result code
+ */
+ @Override
+ public Map<String, Object> transferOwnedData(int transferredUserId, int receivedUserId, List<Integer> transferredIds) {
+ Map<String, Object> result = new HashMap<>();
+
+ List<DataSource> dataSources = dataSourceMapper.selectList(Wrappers.<DataSource>lambdaQuery()
+ .eq(DataSource::getUserId, transferredUserId)
+ .in(DataSource::getId, transferredIds)
+ );
+ Set<Integer> realDataSourceIds = dataSources.stream().map(DataSource::getId).collect(Collectors.toSet());
+ // update datasource owner
+ int updatedDatasourceNum = dataSourceMapper.update(null, Wrappers.<DataSource>lambdaUpdate()
Review comment:
Yes, it has been modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter edited a comment on pull request #7026: [Improvement-6725][API+UI]: Support to change the owner of project/datasource/resource/udfFunc
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #7026:
URL: https://github.com/apache/dolphinscheduler/pull/7026#issuecomment-980561237
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/7026?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7026](https://codecov.io/gh/apache/dolphinscheduler/pull/7026?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f135938) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/ed9fca6c976761abcf4cef2656b61516fd976ad0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ed9fca6) will **decrease** coverage by `0.07%`.
> The diff coverage is `33.33%`.
[](https://codecov.io/gh/apache/dolphinscheduler/pull/7026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## dev #7026 +/- ##
============================================
- Coverage 40.30% 40.22% -0.08%
- Complexity 3655 3668 +13
============================================
Files 653 656 +3
Lines 26917 27121 +204
Branches 3005 3029 +24
============================================
+ Hits 10848 10910 +62
- Misses 15044 15183 +139
- Partials 1025 1028 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/7026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...lphinscheduler/api/controller/UsersController.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvVXNlcnNDb250cm9sbGVyLmphdmE=) | `53.84% <0.00%> (-4.49%)` | :arrow_down: |
| [...phinscheduler/api/exceptions/ServiceException.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2V4Y2VwdGlvbnMvU2VydmljZUV4Y2VwdGlvbi5qYXZh) | `61.11% <0.00%> (-12.23%)` | :arrow_down: |
| [...heduler/api/service/impl/ResourcesServiceImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9SZXNvdXJjZXNTZXJ2aWNlSW1wbC5qYXZh) | `48.82% <0.00%> (-3.62%)` | :arrow_down: |
| [...scheduler/api/service/impl/UdfFuncServiceImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9VZGZGdW5jU2VydmljZUltcGwuamF2YQ==) | `66.19% <0.00%> (-19.26%)` | :arrow_down: |
| [...ache/dolphinscheduler/api/utils/ResourceUtils.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3V0aWxzL1Jlc291cmNlVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...rg/apache/dolphinscheduler/dao/entity/UdfFunc.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9VZGZGdW5jLmphdmE=) | `79.24% <ø> (ø)` | |
| [...inscheduler/api/service/impl/UsersServiceImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9Vc2Vyc1NlcnZpY2VJbXBsLmphdmE=) | `76.90% <47.82%> (+2.13%)` | :arrow_up: |
| [...eduler/api/service/impl/DataSourceServiceImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9EYXRhU291cmNlU2VydmljZUltcGwuamF2YQ==) | `53.40% <94.73%> (+4.56%)` | :arrow_up: |
| [...scheduler/api/service/impl/ProjectServiceImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9Qcm9qZWN0U2VydmljZUltcGwuamF2YQ==) | `76.00% <94.73%> (+1.96%)` | :arrow_up: |
| [.../org/apache/dolphinscheduler/api/enums/Status.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2VudW1zL1N0YXR1cy5qYXZh) | `100.00% <100.00%> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/dolphinscheduler/pull/7026/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/7026?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/7026?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ed9fca6...f135938](https://codecov.io/gh/apache/dolphinscheduler/pull/7026?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] removed a comment on pull request #7026: [Improvement-6725][API+UI]: Support to change the owner of project/datasource/resource/udfFunc
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #7026:
URL: https://github.com/apache/dolphinscheduler/pull/7026#issuecomment-985987867
SonarCloud Quality Gate failed. 
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=CODE_SMELL) [11 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7026&metric=new_coverage&view=list) [32.2% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7026&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7026&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7026&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #7026: [Improvement-6725][API+UI]: Support to change the owner of project/datasource/resource/udfFunc
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #7026:
URL: https://github.com/apache/dolphinscheduler/pull/7026#issuecomment-985998959
SonarCloud Quality Gate failed. 
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=CODE_SMELL) [10 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7026&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7026&metric=new_coverage&view=list) [32.2% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7026&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7026&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7026&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #7026: [Improvement-6725][API+UI]: Support to change the owner of project/datasource/resource/udfFunc
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #7026:
URL: https://github.com/apache/dolphinscheduler/pull/7026#issuecomment-980561237
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/7026?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7026](https://codecov.io/gh/apache/dolphinscheduler/pull/7026?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1657830) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/1fdbc3270c010d31485b2dfb79243a2300e58759?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1fdbc32) will **decrease** coverage by `0.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dolphinscheduler/pull/7026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## dev #7026 +/- ##
============================================
- Coverage 32.83% 32.67% -0.16%
+ Complexity 1620 1606 -14
============================================
Files 432 431 -1
Lines 14377 14340 -37
Branches 1446 1437 -9
============================================
- Hits 4720 4685 -35
+ Misses 9205 9203 -2
Partials 452 452
```
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/7026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...er/master/dispatch/host/assign/RandomSelector.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9ob3N0L2Fzc2lnbi9SYW5kb21TZWxlY3Rvci5qYXZh) | `77.77% <0.00%> (-5.56%)` | :arrow_down: |
| [.../org/apache/dolphinscheduler/common/graph/DAG.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2dyYXBoL0RBRy5qYXZh) | `96.00% <0.00%> (ø)` | |
| [...org/apache/dolphinscheduler/common/enums/Flag.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL0ZsYWcuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...g/apache/dolphinscheduler/common/enums/Direct.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL0RpcmVjdC5qYXZh) | `100.00% <0.00%> (ø)` | |
| [.../apache/dolphinscheduler/common/enums/RunMode.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL1J1bk1vZGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../apache/dolphinscheduler/common/enums/UdfType.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL1VkZlR5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../apache/dolphinscheduler/common/utils/OSUtils.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL09TVXRpbHMuamF2YQ==) | `13.88% <0.00%> (ø)` | |
| [...apache/dolphinscheduler/common/enums/DataType.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL0RhdGFUeXBlLmphdmE=) | `100.00% <0.00%> (ø)` | |
| [...apache/dolphinscheduler/common/enums/NodeType.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL05vZGVUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...apache/dolphinscheduler/common/enums/Priority.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL1ByaW9yaXR5LmphdmE=) | `83.33% <0.00%> (ø)` | |
| ... and [57 more](https://codecov.io/gh/apache/dolphinscheduler/pull/7026/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/7026?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/7026?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1fdbc32...1657830](https://codecov.io/gh/apache/dolphinscheduler/pull/7026?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org