[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4268: Derive Default for WriterProperties

["tustvold (via GitHub)" <gi...@apache.org>]

tustvold commented on code in PR #4268:
URL: https://github.com/apache/arrow-rs/pull/4268#discussion_r1204798484


##########
parquet/src/file/properties.rs:
##########
@@ -130,6 +130,12 @@ pub struct WriterProperties {
     sorting_columns: Option<Vec<SortingColumn>>,
 }
 
+impl Default for WriterProperties {
+    fn default() -> Self {
+        Self::builder().build()
+    }
+}
+
 impl WriterProperties {

Review Comment:
   I prefer default as it indicates the default properties, but have added a new constructor as well



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org