[GitHub] [tvm] pfk-beta commented on pull request #11126: [PY] refactoring - move devices-related functions from tvm.runtime.ndarray

[GitBox <gi...@apache.org>]

pfk-beta commented on PR #11126:
URL: https://github.com/apache/tvm/pull/11126#issuecomment-1110808221

   > Re-exposing the devices under tvm.runtime namespace
   
   You mean devices - functions, not module which I created, right? They were already exposed, I just standrized imports and usage of them. Even python api documentation list these functions in tvm.runtime (https://tvm.apache.org/docs/reference/api/python/runtime.html)
   
   > From UX's pov we intentionally expose tvm.cpu/tvm.cuda not for internal development but for users, so we would like to keep those exposures to avoid API breaking.
   
   That is why, I didn't remove devices functions from top `tvm` module. I think we should put this informations in guideline for python developers, which want to contribute to TVM. Because I refactored mix of usage, and I don't want do this again :) Is there such guideline, or should we create one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org