You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/07/17 12:00:19 UTC

[GitHub] [shardingsphere] mayank-aggarwal28 opened a new pull request, #19292: Added tests for MetaDataContextsFactory

mayank-aggarwal28 opened a new pull request, #19292:
URL: https://github.com/apache/shardingsphere/pull/19292

   Fixes #19262.
   
   Changes proposed in this pull request:
   - Added 3 tests for MetaDataContextsFactory
   - Covers 2 success scenarios and 1 failure scenario
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on pull request #19292: Added tests for MetaDataContextsFactory

Posted by GitBox <gi...@apache.org>.
terrymanu commented on PR #19292:
URL: https://github.com/apache/shardingsphere/pull/19292#issuecomment-1212708292

   @mayank-aggarwal28 The progress of this PR has not been upgraded for a long time. If there is no update, I will close it soon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu closed pull request #19292: Added tests for MetaDataContextsFactory

Posted by GitBox <gi...@apache.org>.
terrymanu closed pull request #19292: Added tests for MetaDataContextsFactory
URL: https://github.com/apache/shardingsphere/pull/19292


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] mayank-aggarwal28 commented on pull request #19292: Added tests for MetaDataContextsFactory

Posted by GitBox <gi...@apache.org>.
mayank-aggarwal28 commented on PR #19292:
URL: https://github.com/apache/shardingsphere/pull/19292#issuecomment-1193286581

   @terrymanu I did not see any compilation errors while running locally on my system. So I am not sure why the pipeline is breaking.
   
   Regarding the test methods, I have refactored them and pushed in a new commit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on pull request #19292: Added tests for MetaDataContextsFactory

Posted by GitBox <gi...@apache.org>.
terrymanu commented on PR #19292:
URL: https://github.com/apache/shardingsphere/pull/19292#issuecomment-1193939711

   The CI still failed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] mayank-aggarwal28 commented on pull request #19292: Added tests for MetaDataContextsFactory

Posted by GitBox <gi...@apache.org>.
mayank-aggarwal28 commented on PR #19292:
URL: https://github.com/apache/shardingsphere/pull/19292#issuecomment-1212711157

   > @mayank-aggarwal28 The progress of this PR has not been upgraded for a long time. If there is no update, I will close it soon.
   
   @terrymanu Please close it for now as I am unable to work on this at the moment due to some urgent commitments. I will open a fresh PR once I am working on this again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on pull request #19292: Added tests for MetaDataContextsFactory

Posted by GitBox <gi...@apache.org>.
terrymanu commented on PR #19292:
URL: https://github.com/apache/shardingsphere/pull/19292#issuecomment-1221455003

   > > @mayank-aggarwal28 The progress of this PR has not been upgraded for a long time. If there is no update, I will close it soon.
   > 
   > @terrymanu Please close it for now as I am unable to work on this at the moment due to some urgent commitments. I will open a fresh PR once I am working on this again.
   
   Ok, welcome come back again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org